From 547f4633d573089b08a4216a3147ee0920458b31 Mon Sep 17 00:00:00 2001 From: Chris Dodge Date: Fri, 12 Jul 2013 12:47:23 -0400 Subject: [PATCH] use better syntax for asserting that exception is thrown --- common/lib/xmodule/xmodule/tests/test_xml_module.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/lib/xmodule/xmodule/tests/test_xml_module.py b/common/lib/xmodule/xmodule/tests/test_xml_module.py index a853e6ab3f..2010ad2b7e 100644 --- a/common/lib/xmodule/xmodule/tests/test_xml_module.py +++ b/common/lib/xmodule/xmodule/tests/test_xml_module.py @@ -203,11 +203,9 @@ class TestSerialize(unittest.TestCase): assert_equals('1 day 12 hours 59 minutes 59 seconds', serialize_string_literal("1 day 12 hours 59 minutes 59 seconds")) - try: + # make sure we can't call serialize_string_literal with a non basestring type + with self.assertRaises(TypeError): self.assertRaises(serialize_string_literal(2.31)) - except Exception: - pass - class TestDeserialize(unittest.TestCase): def assertDeserializeEqual(self, expected, arg):