diff --git a/common/static/common/js/discussion/views/discussion_topic_menu_view.js b/common/static/common/js/discussion/views/discussion_topic_menu_view.js index bb1e88cbdb..7079972541 100644 --- a/common/static/common/js/discussion/views/discussion_topic_menu_view.js +++ b/common/static/common/js/discussion/views/discussion_topic_menu_view.js @@ -46,7 +46,7 @@ '[data-discussion-id="' + this.getCurrentTopicId() + '"]') ); } else { - this.setTopic(this.$('.topic-title').first()); + this.setTopic(this.$('button.topic-title').first()); } return this.$el; }, diff --git a/common/static/common/js/discussion/views/new_post_view.js b/common/static/common/js/discussion/views/new_post_view.js index 6d2396870b..f06e5d6cac 100644 --- a/common/static/common/js/discussion/views/new_post_view.js +++ b/common/static/common/js/discussion/views/new_post_view.js @@ -177,7 +177,7 @@ DiscussionUtil.clearFormErrors(this.$('.post-errors')); this.$('.wmd-preview p').html(''); if (this.isTabMode()) { - return this.topicView.setTopic(this.$('.topic-title').first()); + return this.topicView.setTopic(this.$('button.topic-title').first()); } }; diff --git a/common/static/common/js/spec/discussion/view/discussion_topic_menu_view_spec.js b/common/static/common/js/spec/discussion/view/discussion_topic_menu_view_spec.js index 08684d9dfd..0ffc3b750b 100644 --- a/common/static/common/js/spec/discussion/view/discussion_topic_menu_view_spec.js +++ b/common/static/common/js/spec/discussion/view/discussion_topic_menu_view_spec.js @@ -135,7 +135,7 @@ var dropdownText; this.createTopicView(); this.view.maxNameWidth = this.selectedOptionText.length + 100; - this.view.$el.find('.topic-title').first().click(); + this.view.$el.find('button.topic-title').first().click(); dropdownText = this.view.$el.find('.js-selected-topic').text(); expect(dropdownText.indexOf('/ span>')).toEqual(-1); }); @@ -152,6 +152,15 @@ expect(completeText).toEqual(dropdownText); }); + it("defaults to the first topic if you don't click one", function() { + this.createTopicView(); + expect( + this.view.$el.find('.js-selected-topic').text() + ).toMatch( + this.view.$el.find('.topic-menu-entry')[0].innerHTML + ); + }); + it('click outside of the dropdown close it', function() { this.createTopicView(); this.openMenu(); diff --git a/lms/static/sass/discussion/views/_create-edit-post.scss b/lms/static/sass/discussion/views/_create-edit-post.scss index c7b39b8316..f9f4be45e7 100644 --- a/lms/static/sass/discussion/views/_create-edit-post.scss +++ b/lms/static/sass/discussion/views/_create-edit-post.scss @@ -257,7 +257,7 @@ font-size: $forum-base-font-size; } - a.topic-title { + button.topic-title { @include transition(none); &:hover, &:focus {