From 5430b3633f6bcfca25e44ed7bc869518647c8eff Mon Sep 17 00:00:00 2001 From: Nimisha Asthagiri Date: Mon, 15 Jan 2018 12:20:27 -0500 Subject: [PATCH] Move COURSE_START_DATE_CHANGED signal --- openedx/core/djangoapps/content/course_overviews/signals.py | 6 +++++- .../content/course_overviews/tests/test_signals.py | 2 +- openedx/core/djangoapps/signals/signals.py | 2 -- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/openedx/core/djangoapps/content/course_overviews/signals.py b/openedx/core/djangoapps/content/course_overviews/signals.py index 81c49692ee..45e8186941 100644 --- a/openedx/core/djangoapps/content/course_overviews/signals.py +++ b/openedx/core/djangoapps/content/course_overviews/signals.py @@ -3,15 +3,19 @@ Signal handler for invalidating cached course overviews """ import logging +from django.dispatch import Signal from django.dispatch.dispatcher import receiver from .models import CourseOverview -from openedx.core.djangoapps.signals.signals import COURSE_PACING_CHANGED, COURSE_START_DATE_CHANGED +from openedx.core.djangoapps.signals.signals import COURSE_PACING_CHANGED from xmodule.modulestore.django import SignalHandler LOG = logging.getLogger(__name__) +COURSE_START_DATE_CHANGED = Signal(providing_args=["updated_course_overview", "previous_start_date"]) + + @receiver(SignalHandler.course_published) def _listen_for_course_publish(sender, course_key, **kwargs): # pylint: disable=unused-argument """ diff --git a/openedx/core/djangoapps/content/course_overviews/tests/test_signals.py b/openedx/core/djangoapps/content/course_overviews/tests/test_signals.py index f97f3719df..35a3e93e56 100644 --- a/openedx/core/djangoapps/content/course_overviews/tests/test_signals.py +++ b/openedx/core/djangoapps/content/course_overviews/tests/test_signals.py @@ -82,7 +82,7 @@ class CourseOverviewSignalsTestCase(ModuleStoreTestCase): self.store.update_item(course, ModuleStoreEnum.UserID.test) self.assertTrue(mock_signal.called) - @patch('openedx.core.djangoapps.signals.signals.COURSE_START_DATE_CHANGED.send') + @patch('openedx.core.djangoapps.content.course_overviews.signals.COURSE_START_DATE_CHANGED.send') def test_start_changed(self, mock_signal): self.assert_changed_signal_sent('start', self.TODAY, self.NEXT_WEEK, mock_signal) diff --git a/openedx/core/djangoapps/signals/signals.py b/openedx/core/djangoapps/signals/signals.py index 7bdb3656fd..79e80df5e8 100644 --- a/openedx/core/djangoapps/signals/signals.py +++ b/openedx/core/djangoapps/signals/signals.py @@ -24,5 +24,3 @@ COURSE_GRADE_NOW_PASSED = Signal( LEARNER_NOW_VERIFIED = Signal(providing_args=['user']) COURSE_PACING_CHANGED = Signal(providing_args=["updated_course_overview", "previous_self_paced"]) - -COURSE_START_DATE_CHANGED = Signal(providing_args=["updated_course_overview", "previous_start_date"])