From 537696d86132dc4d4bb45f9ee907e7cd210dac63 Mon Sep 17 00:00:00 2001 From: Calen Pennington Date: Tue, 26 Mar 2019 14:33:12 -0400 Subject: [PATCH] Don't use multiple bins per course when sending Access Expiry Emails --- .../course_duration_limits/resolvers.py | 2 +- .../features/course_duration_limits/tasks.py | 26 +++++++++---------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/openedx/features/course_duration_limits/resolvers.py b/openedx/features/course_duration_limits/resolvers.py index c5402e5480..f94e2426e1 100644 --- a/openedx/features/course_duration_limits/resolvers.py +++ b/openedx/features/course_duration_limits/resolvers.py @@ -27,7 +27,7 @@ from .models import CourseDurationLimitConfig LOG = logging.getLogger(__name__) DEFAULT_NUM_BINS = 24 -EXPIRY_REMINDER_NUM_BINS = 24 +EXPIRY_REMINDER_NUM_BINS = 1 EXPIRY_REMINDER_LOG_PREFIX = 'FBE Expiry Reminder' diff --git a/openedx/features/course_duration_limits/tasks.py b/openedx/features/course_duration_limits/tasks.py index 144d8b3ab6..9973d6d4bc 100644 --- a/openedx/features/course_duration_limits/tasks.py +++ b/openedx/features/course_duration_limits/tasks.py @@ -75,22 +75,20 @@ class CourseDurationLimitMessageBaseTask(LoggedTask): continue target_date = current_date + datetime.timedelta(days=day_offset) - for bin_num in range(cls.num_bins): - task_args = ( - site.id, - unicode(course_key), - serialize(target_date), - day_offset, - bin_num, - override_recipient_email, - ) - cls().apply_async( - task_args, - retry=False, - ) + task_args = ( + site.id, + unicode(course_key), + serialize(target_date), + day_offset, + override_recipient_email, + ) + cls().apply_async( + task_args, + retry=False, + ) def run( # pylint: disable=arguments-differ - self, site_id, course_key_str, target_day_str, day_offset, bin_num, override_recipient_email=None, + self, site_id, course_key_str, target_day_str, day_offset, override_recipient_email=None, ): try: site = Site.objects.select_related('configuration').get(id=site_id)