From 52c15d4637704d6a8f2fe9f9882aea058951438f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Thu, 12 Apr 2018 11:08:51 +0200 Subject: [PATCH] Fix disabled login/register buttons after failed attempt In the login window, when the user enter a wrong email or password, the "Log into my ... account" button used to remain disabled, which was very confusing for users. Steps to reproduce: - Go to /login - Type wrong email/password combination - Press "Log into..." button Similarly, users could not click the "register button after a failed register attempt. For example, this occurred to users with an invalid email address, such as "fooatgmaildotcom". --- lms/templates/login.html | 2 +- lms/templates/register.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lms/templates/login.html b/lms/templates/login.html index 5b81c5fda6..bd8060685f 100644 --- a/lms/templates/login.html +++ b/lms/templates/login.html @@ -100,7 +100,7 @@ from third_party_auth import provider, pipeline $submitButton. removeClass('is-disabled'). attr('aria-disabled', false). - removeProp('disabled'). + prop('disabled', false). html("${_('Log into My {platform_name} Account').format(platform_name=platform_name)} + ${_('Access My Courses')}"); } else { diff --git a/lms/templates/register.html b/lms/templates/register.html index b273dbf36d..1eaff34fe3 100644 --- a/lms/templates/register.html +++ b/lms/templates/register.html @@ -85,7 +85,7 @@ import calendar $submitButton. removeClass('is-disabled'). attr('aria-disabled', false). - removeProp('disabled'). + prop('disabled', false). html("${_('Create My {platform_name} Account').format(platform_name=platform_name)}"); } else {