diff --git a/common/lib/xmodule/xmodule/modulestore/tests/django_utils.py b/common/lib/xmodule/xmodule/modulestore/tests/django_utils.py index 1998ae2978..2a05094abc 100644 --- a/common/lib/xmodule/xmodule/modulestore/tests/django_utils.py +++ b/common/lib/xmodule/xmodule/modulestore/tests/django_utils.py @@ -4,7 +4,6 @@ Modulestore configuration for test cases. """ import datetime import pytz -from tempfile import mkdtemp from uuid import uuid4 from mock import patch @@ -16,6 +15,8 @@ from django.test.utils import override_settings from request_cache.middleware import RequestCache from courseware.field_overrides import OverrideFieldData # pylint: disable=import-error +from openedx.core.lib.tempdir import mkdtemp_clean + from xmodule.contentstore.django import _CONTENTSTORE from xmodule.modulestore import ModuleStoreEnum from xmodule.modulestore.django import modulestore, clear_existing_modulestores @@ -184,13 +185,13 @@ TEST_DATA_MIXED_GRADED_MODULESTORE = mixed_store_config( # All store requests now go through mixed # Use this modulestore if you specifically want to test mongo and not a mocked modulestore. # This modulestore definition below will not load any xml courses. -TEST_DATA_MONGO_MODULESTORE = mixed_store_config(mkdtemp(), {}, include_xml=False) +TEST_DATA_MONGO_MODULESTORE = mixed_store_config(mkdtemp_clean(), {}, include_xml=False) # All store requests now go through mixed # Use this modulestore if you specifically want to test split-mongo and not a mocked modulestore. # This modulestore definition below will not load any xml courses. TEST_DATA_SPLIT_MODULESTORE = mixed_store_config( - mkdtemp(), + mkdtemp_clean(), {}, include_xml=False, store_order=[StoreConstructors.split, StoreConstructors.draft] @@ -235,7 +236,7 @@ class ModuleStoreTestCase(TestCase): your `setUp()` method. """ - MODULESTORE = mixed_store_config(mkdtemp(), {}, include_xml=False) + MODULESTORE = mixed_store_config(mkdtemp_clean(), {}, include_xml=False) def setUp(self, **kwargs): """ diff --git a/common/lib/xmodule/xmodule/modulestore/tests/test_modulestore_settings.py b/common/lib/xmodule/xmodule/modulestore/tests/test_modulestore_settings.py index dea9ee8d52..35b232e083 100644 --- a/common/lib/xmodule/xmodule/modulestore/tests/test_modulestore_settings.py +++ b/common/lib/xmodule/xmodule/modulestore/tests/test_modulestore_settings.py @@ -3,7 +3,8 @@ Tests for testing the modulestore settings migration code. """ import copy import ddt -from tempfile import mkdtemp + +from openedx.core.lib.tempdir import mkdtemp_clean from unittest import TestCase from xmodule.modulestore.modulestore_settings import ( @@ -37,7 +38,7 @@ class ModuleStoreSettingsMigration(TestCase): "collection": "modulestore", "db": "edxapp", "default_class": "xmodule.hidden_module.HiddenDescriptor", - "fs_root": mkdtemp(), + "fs_root": mkdtemp_clean(), "host": "localhost", "password": "password", "port": 27017, diff --git a/lms/envs/test.py b/lms/envs/test.py index 8c7cc0b0ca..9cf5251a37 100644 --- a/lms/envs/test.py +++ b/lms/envs/test.py @@ -21,10 +21,11 @@ sessions. Assumes structure: from .common import * import os from path import path -from tempfile import mkdtemp from uuid import uuid4 from warnings import filterwarnings, simplefilter +from openedx.core.lib.tempdir import mkdtemp_clean + # Silence noisy logs to make troubleshooting easier when tests fail. import logging LOG_OVERRIDES = [ @@ -151,7 +152,7 @@ update_module_store_settings( 'fs_root': TEST_ROOT / "data", }, xml_store_options={ - 'data_dir': mkdtemp(dir=TEST_ROOT), # never inadvertently load all the XML courses + 'data_dir': mkdtemp_clean(dir=TEST_ROOT), # never inadvertently load all the XML courses }, doc_store_settings={ 'host': MONGO_HOST,