Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LMS: correcting poorly scoped font-family rule for footer links inside of p, ul, ol elements.

Browse Source 
Fix link stylings in LMS and CMS footers
This commit is contained in:
Sarina Canelake
2015-02-02 15:23:01 -05:00
parent 4b6c62a85b
commit 4fc4b2f3de
3 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cms/templates/widgets/footer.html
View File

@@ -4,12 +4,12 @@
<div class="wrapper-footer wrapper"> <div class="wrapper-footer wrapper">
<footer class="primary" role="contentinfo"> <footer class="primary" role="contentinfo">
<div class="colophon"> <div class="colophon">
<p>&copy; ${settings.COPYRIGHT_YEAR} <a href="${marketing_link('ROOT')}" rel="external">${settings.PLATFORM_NAME}</a>.</p> <p>&copy; ${settings.COPYRIGHT_YEAR} <a data-rel="edx.org" href="${marketing_link('ROOT')}" rel="external">${settings.PLATFORM_NAME}</a>.</p>
## Site operators: Please do not remove this paragraph! This attributes back to edX and makes your acknowledgement of edX's trademarks clear. ## Site operators: Please do not remove this paragraph! This attributes back to edX and makes your acknowledgement of edX's trademarks clear.
<p> <p>
## Translators: 'EdX', 'edX', 'Studio', and 'Open edX' are trademarks of 'edX Inc.'. Please do not translate any of these trademarks and company names. ## Translators: 'EdX', 'edX', 'Studio', and 'Open edX' are trademarks of 'edX Inc.'. Please do not translate any of these trademarks and company names.
${_("EdX, Open edX, Studio, and the edX and Open edX logos are registered trademarks or trademarks of {link_start}edX Inc.{link_end}").format( ${_("EdX, Open edX, Studio, and the edX and Open edX logos are registered trademarks or trademarks of {link_start}edX Inc.{link_end}").format(
link_start=u"<a href='https://www.edx.org/'>", link_start=u"<a data-rel='edx.org' href='https://www.edx.org/'>",
link_end=u"</a>" link_end=u"</a>"
)} )}
</p> </p>
@@ -25,7 +25,7 @@
</li> </li>
% if settings.TENDER_DOMAIN and user.is_authenticated(): % if settings.TENDER_DOMAIN and user.is_authenticated():
<li class="nav-item nav-peripheral-feedback"> <li class="nav-item nav-peripheral-feedback">
<a href="http://${settings.TENDER_DOMAIN}/discussion/new" class="show-tender" title="${_('Use our feedback tool, Tender, to share your feedback')}">${_("Contact Us")}</a> <a data-rel="edx.org" href="http://${settings.TENDER_DOMAIN}/discussion/new" class="show-tender" title="${_('Use our feedback tool, Tender, to share your feedback')}">${_("Contact Us")}</a>
</li> </li>
% endif % endif
</ol> </ol>

12
lms/static/sass/shared/_footer.scss
View File

@@ -20,6 +20,11 @@
p, ol, ul { p, ol, ul {
font-family: $sans-serif; font-family: $sans-serif;
// override needed for poorly scoped font-family styling on p a:link {}
a {
font-family: $sans-serif;
}
} }
a { a {
@@ -27,7 +32,6 @@
border-bottom: none; border-bottom: none;
color: $link-color; color: $link-color;
text-decoration: none !important; text-decoration: none !important;
font-family: $sans-serif;
&:hover, &:focus, &:active { &:hover, &:focus, &:active {
border-bottom: 1px dotted $link-color; border-bottom: 1px dotted $link-color;
@@ -327,6 +331,12 @@ $edx-footer-bg-color: rgb(252,252,252);
// NOTE: needed for poor LMS span styling // NOTE: needed for poor LMS span styling
color: inherit; color: inherit;
} }
a {
@extend %edx-footer-link;
display: inline-block;
margin-bottom: ($edx-footer-spacing/2);
}
} }
.footer-about-links { .footer-about-links {

20
lms/templates/footer-edx-new.html
View File

@@ -30,17 +30,17 @@
</div> </div>
<div class="footer-about-copyright"> <div class="footer-about-copyright">
## Using "edX Inc." explicitly here for copyright purposes (settings.PLATFORM_NAME is just "edX", and this footer is only used on edx.org) ## Using "edX Inc." explicitly here for copyright purposes (settings.PLATFORM_NAME is just "edX", and this footer is only used on edx.org)
<p>&copy; ${settings.COPYRIGHT_YEAR} edX Inc.</p> <p>&copy; ${settings.COPYRIGHT_YEAR} edX Inc.</p>
## Site operators: Please do not remove this paragraph! This attributes back to edX and makes your acknowledgement of edX's trademarks clear. ## Site operators: Please do not remove this paragraph! This attributes back to edX and makes your acknowledgement of edX's trademarks clear.
<p> <p>
## Translators: 'EdX', 'edX', and 'Open edX' are trademarks of 'edX Inc.'. Please do not translate any of these trademarks and company names. ## Translators: 'EdX', 'edX', and 'Open edX' are trademarks of 'edX Inc.'. Please do not translate any of these trademarks and company names.
${_("EdX, Open edX, and the edX and Open edX logos are registered trademarks or trademarks of {link_start}edX Inc.{link_end}").format( ${_("EdX, Open edX, and the edX and Open edX logos are registered trademarks or trademarks of {link_start}edX Inc.{link_end}").format(
link_start=u"<a href='https://www.edx.org/'>", link_start=u"<a href='https://www.edx.org/'><span class='copy'>",
link_end=u"</a>" link_end=u"</span></a>"
)} )}
</p> </p>
</div> </div>
<div class="footer-about-links"> <div class="footer-about-links">