From 4af79d6f76923b61f1c19f6b5e68cd1eb3e168fc Mon Sep 17 00:00:00 2001 From: cahrens Date: Tue, 21 Apr 2015 16:03:59 -0400 Subject: [PATCH] Don't event first_name and last_name. TNL-2044 --- common/djangoapps/student/models.py | 2 +- common/djangoapps/student/tests/test_events.py | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/common/djangoapps/student/models.py b/common/djangoapps/student/models.py index 58ecd581b9..a783b60a48 100644 --- a/common/djangoapps/student/models.py +++ b/common/djangoapps/student/models.py @@ -374,7 +374,7 @@ def user_post_save_callback(sender, **kwargs): user, user, sender._meta.db_table, - excluded_fields=['last_login'], + excluded_fields=['last_login', 'first_name', 'last_name'], hidden_fields=['password'] ) diff --git a/common/djangoapps/student/tests/test_events.py b/common/djangoapps/student/tests/test_events.py index 9640b50dc1..ea822c98e9 100644 --- a/common/djangoapps/student/tests/test_events.py +++ b/common/djangoapps/student/tests/test_events.py @@ -146,3 +146,12 @@ class TestUserEvents(UserSettingsEventTestMixin, TestCase): with self.assertRaises(IntegrityError): self.user.save() self.assert_no_events_were_emitted() + + def test_no_first_and_last_name_events(self): + """ + Verify that first_name and last_name events are not emitted. + """ + self.user.first_name = "Donald" + self.user.last_name = "Duck" + self.user.save() + self.assert_no_events_were_emitted()