From 4a1154a7ca5af6c7ed7f0193433febc79f1005b0 Mon Sep 17 00:00:00 2001 From: Ned Batchelder Date: Thu, 16 May 2019 14:41:28 -0400 Subject: [PATCH] Give a safer buffer for clearing the rate limiting The rate limiter counts requests in a 5-minute window. To be sure we aren't hitting edge cases, make the future requests 6 minutes plus 1 second in the future. --- lms/djangoapps/shoppingcart/tests/test_views.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lms/djangoapps/shoppingcart/tests/test_views.py b/lms/djangoapps/shoppingcart/tests/test_views.py index 0a5cd7bf99..dd18a89a7e 100644 --- a/lms/djangoapps/shoppingcart/tests/test_views.py +++ b/lms/djangoapps/shoppingcart/tests/test_views.py @@ -1749,8 +1749,8 @@ class RegistrationCodeRedemptionCourseEnrollment(SharedModuleStoreTestCase): response = self.client.post(url) self.assertEquals(response.status_code, 403) - # now reset the time to 5 mins from now in future in order to unblock - reset_time = datetime.now(UTC) + timedelta(seconds=300) + # now reset the time to 6 mins from now in future in order to unblock + reset_time = datetime.now(UTC) + timedelta(seconds=361) with freeze_time(reset_time): response = self.client.post(url) self.assertEquals(response.status_code, 404) @@ -1773,8 +1773,8 @@ class RegistrationCodeRedemptionCourseEnrollment(SharedModuleStoreTestCase): response = self.client.get(url) self.assertEquals(response.status_code, 403) - # now reset the time to 5 mins from now in future in order to unblock - reset_time = datetime.now(UTC) + timedelta(seconds=300) + # now reset the time to 6 mins from now in future in order to unblock + reset_time = datetime.now(UTC) + timedelta(seconds=361) with freeze_time(reset_time): response = self.client.get(url) self.assertEquals(response.status_code, 404)