From 49bd356766e74eb7dc569f6408cf1d6b31d82fd7 Mon Sep 17 00:00:00 2001 From: jmclaus Date: Fri, 11 Oct 2013 14:33:44 +0200 Subject: [PATCH] Used chaining. Cached gettext call. --- .../js/src/video/05_video_quality_control.js | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js b/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js index bc3a33b799..fc8449c8d2 100644 --- a/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js +++ b/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js @@ -59,16 +59,22 @@ function () { // *************************************************************** function onQualityChange(value) { + var controlStateStr; this.videoQualityControl.quality = value; if (_.indexOf(this.config.availableQualities, value) !== -1) { - this.videoQualityControl.el.addClass('active'); - this.videoQualityControl.el.attr('title', gettext('HD on')) - .text(gettext('HD on')); + controlStateStr = gettext('HD on'); + this.videoQualityControl.el + .addClass('active') + .attr('title', controlStateStr) + .text(controlStateStr); } else { - this.videoQualityControl.el.removeClass('active'); - this.videoQualityControl.el.attr('title', gettext('HD off')) - .text(gettext('HD off')); + controlStateStr = gettext('HD off'); + this.videoQualityControl.el + .removeClass('active') + .attr('title', controlStateStr) + .text(controlStateStr); + } }