From ff4a39a0db54c6ac9de85835b31ec21e6458adb4 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Apr 2019 13:47:12 -0400 Subject: [PATCH 1/5] An initial breakdown of our areas of the monolith. Right now there are no owners associated but this should clarify what is considered part of the core and core extensions. This is not a full list so things will have to be added as we find that they need an owner and don't have one. This list was taken by looking at the parts of our codebase that is most executed for edx.org and so should represent the most important things that should probably have owners. --- .github/CODEOWNERS | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..6a0c71a7e6 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,42 @@ +# This does not cover all the code in edx-platform but it's a good start. + +# Core +common/djangoapps/third_party_auth/ +common/lib/xmodule/xmodule/ +lms/djangoapps/course_api/blocks +lms/djangoapps/courseware/ +lms/djangoapps/grades/ +lms/djangoapps/instructor/ +lms/djangoapps/mobile_api/ +openedx/core/djangoapps/contentserver/ +openedx/core/djangoapps/heartbeat/ +openedx/core/djangoapps/oauth_dispatch +openedx/core/djangoapps/user_api/ +openedx/core/djangoapps/user_authn/ +openedx/features/course_experience/ + +# Core Extensions +common/lib/xmodule/xmodule/capa_module.py +common/lib/xmodule/xmodule/html_module.py +common/lib/xmodule/xmodule/video_module +lms/djangoapps/courseware/ +lms/djangoapps/discussion/ +lms/djangoapps/discussion_api/ +lms/djangoapps/edxnotes +lms/djangoapps/notifier_api/ + +# Analytics +common/djangoapps/track/ + +# Credentials +lms/djangoapps/certificates/ + +# Discovery +common/djangoapps/course_modes/ +common/djangoapps/enrollment/ +common/djangoapps/student +lms/djangoapps/commerce/ +lms/djangoapps/courseware/ +lms/djangoapps/experiments/ +lms/djangoapps/learner_dashboard/ +lms/djangoapps/mobile_api/ From 22cc45bb618716c94506377f87f5c1c9de14f2d8 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Apr 2019 14:40:11 -0400 Subject: [PATCH 2/5] Cleanup based on review. --- .github/CODEOWNERS | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 6a0c71a7e6..bb65821a2b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,7 @@ # This does not cover all the code in edx-platform but it's a good start. # Core +common/djangoapps/student/ common/djangoapps/third_party_auth/ common/lib/xmodule/xmodule/ lms/djangoapps/course_api/blocks @@ -19,7 +20,6 @@ openedx/features/course_experience/ common/lib/xmodule/xmodule/capa_module.py common/lib/xmodule/xmodule/html_module.py common/lib/xmodule/xmodule/video_module -lms/djangoapps/courseware/ lms/djangoapps/discussion/ lms/djangoapps/discussion_api/ lms/djangoapps/edxnotes @@ -34,9 +34,6 @@ lms/djangoapps/certificates/ # Discovery common/djangoapps/course_modes/ common/djangoapps/enrollment/ -common/djangoapps/student lms/djangoapps/commerce/ -lms/djangoapps/courseware/ lms/djangoapps/experiments/ lms/djangoapps/learner_dashboard/ -lms/djangoapps/mobile_api/ From 6b89f9b257692c96baf030dff5866eaec41ed4d2 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Apr 2019 15:40:55 -0400 Subject: [PATCH 3/5] Assign teams to code areas. --- .github/CODEOWNERS | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index bb65821a2b..56c6956bb7 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2,31 +2,32 @@ # Core common/djangoapps/student/ -common/djangoapps/third_party_auth/ +common/djangoapps/third_party_auth/ @edx/platform-authn common/lib/xmodule/xmodule/ lms/djangoapps/course_api/blocks lms/djangoapps/courseware/ -lms/djangoapps/grades/ +lms/djangoapps/grades/ @edx/platform-grades lms/djangoapps/instructor/ -lms/djangoapps/mobile_api/ +lms/djangoapps/instructor_task/ +lms/djangoapps/mobile_api/ @edx/platform-mobile openedx/core/djangoapps/contentserver/ openedx/core/djangoapps/heartbeat/ -openedx/core/djangoapps/oauth_dispatch -openedx/core/djangoapps/user_api/ -openedx/core/djangoapps/user_authn/ -openedx/features/course_experience/ +openedx/core/djangoapps/oauth_dispatch @edx/platform-authn +openedx/core/djangoapps/user_api/ @edx/platform-authn +openedx/core/djangoapps/user_authn/ @edx/platform-authn +openedx/features/course_experience/ @edx/platform-courseware # Core Extensions -common/lib/xmodule/xmodule/capa_module.py -common/lib/xmodule/xmodule/html_module.py -common/lib/xmodule/xmodule/video_module -lms/djangoapps/discussion/ -lms/djangoapps/discussion_api/ -lms/djangoapps/edxnotes -lms/djangoapps/notifier_api/ +common/lib/xmodule/xmodule/capa_module.py @edx/platform-core-extensions +common/lib/xmodule/xmodule/html_module.py @edx/platform-core-extensions +common/lib/xmodule/xmodule/video_module @edx/platform-core-extensions +lms/djangoapps/discussion/ @edx/platform-core-extensions +lms/djangoapps/discussion_api/ @edx/platform-core-extensions +lms/djangoapps/edxnotes @edx/platform-core-extensions +lms/djangoapps/notifier_api/ @edx/platform-core-extensions # Analytics -common/djangoapps/track/ +common/djangoapps/track/ @edx/edx-data-engineering # Credentials lms/djangoapps/certificates/ @@ -34,6 +35,8 @@ lms/djangoapps/certificates/ # Discovery common/djangoapps/course_modes/ common/djangoapps/enrollment/ -lms/djangoapps/commerce/ -lms/djangoapps/experiments/ +lms/djangoapps/commerce/ @edx/ecommerce +lms/djangoapps/experiments/ @edx/rev-team lms/djangoapps/learner_dashboard/ +openedx/features/content_type_gating/ @edx/rev-team +openedx/features/course_duration_limits/ @edx/rev-team From bd3625570db3500c523753f24d1839179d507c9b Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Apr 2019 15:47:47 -0400 Subject: [PATCH 4/5] Add in some more teams. --- .github/CODEOWNERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 56c6956bb7..cb6cebc4e5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -30,13 +30,13 @@ lms/djangoapps/notifier_api/ @edx/platform-core-extensions common/djangoapps/track/ @edx/edx-data-engineering # Credentials -lms/djangoapps/certificates/ +lms/djangoapps/certificates/ @edx/platform-credentials # Discovery -common/djangoapps/course_modes/ -common/djangoapps/enrollment/ +common/djangoapps/course_modes/ @edx/platform-discovery +common/djangoapps/enrollment/ @edx/platform-discovery lms/djangoapps/commerce/ @edx/ecommerce lms/djangoapps/experiments/ @edx/rev-team -lms/djangoapps/learner_dashboard/ +lms/djangoapps/learner_dashboard/ @edx/platform-discovery openedx/features/content_type_gating/ @edx/rev-team openedx/features/course_duration_limits/ @edx/rev-team From 3c8b7f4988b7e47f3dfe5b58117bfc2e786ca97b Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Apr 2019 15:55:19 -0400 Subject: [PATCH 5/5] Map areas to the core team. Have a platform-core team that can be responsible for everything that is not already being owned by a more specific group. --- .github/CODEOWNERS | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cb6cebc4e5..b102efcfe1 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,17 +1,17 @@ # This does not cover all the code in edx-platform but it's a good start. # Core -common/djangoapps/student/ +common/djangoapps/student/ @edx/platform-core common/djangoapps/third_party_auth/ @edx/platform-authn -common/lib/xmodule/xmodule/ -lms/djangoapps/course_api/blocks -lms/djangoapps/courseware/ +common/lib/xmodule/xmodule/ @edx/platform-core +lms/djangoapps/course_api/blocks @edx/platform-core +lms/djangoapps/courseware/ @edx/platform-core lms/djangoapps/grades/ @edx/platform-grades -lms/djangoapps/instructor/ -lms/djangoapps/instructor_task/ +lms/djangoapps/instructor/ @edx/platform-core +lms/djangoapps/instructor_task/ @edx/platform-core lms/djangoapps/mobile_api/ @edx/platform-mobile -openedx/core/djangoapps/contentserver/ -openedx/core/djangoapps/heartbeat/ +openedx/core/djangoapps/contentserver/ @edx/platform-core +openedx/core/djangoapps/heartbeat/ @edx/platform-core openedx/core/djangoapps/oauth_dispatch @edx/platform-authn openedx/core/djangoapps/user_api/ @edx/platform-authn openedx/core/djangoapps/user_authn/ @edx/platform-authn