From c6344aa5775be4263e48622907ce3ef64a609b1b Mon Sep 17 00:00:00 2001
From: "Dave St.Germain" <dstgermain@edx.org>
Date: Thu, 14 May 2020 07:49:37 -0400
Subject: [PATCH] Only the data download tab should appear for data researchers
 TNL-7222

---
 .../tests/views/test_instructor_dashboard.py  | 22 +++++++++++++++++++
 .../instructor/views/instructor_dashboard.py  |  4 ++--
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py b/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py
index c3bf7b07a6..7bd2d561b1 100644
--- a/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py
+++ b/lms/djangoapps/instructor/tests/views/test_instructor_dashboard.py
@@ -4,6 +4,7 @@ Unit tests for instructor_dashboard.py.
 
 
 import datetime
+import re
 
 import ddt
 import six
@@ -162,6 +163,27 @@ class TestInstructorDashboard(ModuleStoreTestCase, LoginEnrollmentTestCase, XssT
         else:
             self.assertNotContains(response, download_section)
 
+    @override_settings(ANALYTICS_DASHBOARD_URL='http://example.com')
+    @override_settings(ANALYTICS_DASHBOARD_NAME='Example')
+    def test_data_download_only(self):
+        """
+        Verify that only the data download tab is visible for data researchers.
+        """
+        user = UserFactory.create()
+        CourseAccessRoleFactory(
+            course_id=self.course.id,
+            user=user,
+            role='data_researcher',
+            org=self.course.id.org
+        )
+        self.client.login(username=user.username, password="test")
+        response = self.client.get(self.url)
+        matches = re.findall(
+            rb'<li class="nav-item"><button type="button" class="btn-link .*" data-section=".*">.*',
+            response.content
+        )
+        assert len(matches) == 1
+
     @ddt.data(
         ("How to defeat the Road Runner", "2017", "001", "ACME"),
     )
diff --git a/lms/djangoapps/instructor/views/instructor_dashboard.py b/lms/djangoapps/instructor/views/instructor_dashboard.py
index 02be7bccf1..21d1a20d6d 100644
--- a/lms/djangoapps/instructor/views/instructor_dashboard.py
+++ b/lms/djangoapps/instructor/views/instructor_dashboard.py
@@ -144,7 +144,7 @@ def instructor_dashboard_2(request, course_id):
         sections.append(_section_data_download(course, access))
 
     analytics_dashboard_message = None
-    if show_analytics_dashboard_message(course_key):
+    if show_analytics_dashboard_message(course_key) and (access['staff'] or access['instructor']):
         # Construct a URL to the external analytics dashboard
         analytics_dashboard_url = '{0}/courses/{1}'.format(settings.ANALYTICS_DASHBOARD_URL, six.text_type(course_key))
         link_start = HTML(u"<a href=\"{}\" rel=\"noopener\" target=\"_blank\">").format(analytics_dashboard_url)
@@ -174,7 +174,7 @@ def instructor_dashboard_2(request, course_id):
         sections.insert(3, _section_extensions(course))
 
     # Gate access to course email by feature flag & by course-specific authorization
-    if is_bulk_email_feature_enabled(course_key):
+    if is_bulk_email_feature_enabled(course_key) and (access['staff'] or access['instructor']):
         sections.append(_section_send_email(course, access))
 
     # Gate access to Ecommerce tab