From 43d975a92a03f8f8b42926f01b22fce9a062a358 Mon Sep 17 00:00:00 2001 From: Calen Pennington Date: Tue, 22 Jan 2019 22:23:50 -0500 Subject: [PATCH] Select related CourseOverview.image_set when loading the course_api --- lms/djangoapps/course_api/tests/test_views.py | 2 +- lms/djangoapps/courseware/courses.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lms/djangoapps/course_api/tests/test_views.py b/lms/djangoapps/course_api/tests/test_views.py index 21f7a82cd7..179b7dd4f3 100644 --- a/lms/djangoapps/course_api/tests/test_views.py +++ b/lms/djangoapps/course_api/tests/test_views.py @@ -392,7 +392,7 @@ class CourseListSearchViewTest(CourseApiTestViewMixin, ModuleStoreTestCase, Sear self.setup_user(self.audit_user) # These query counts were found empirically - query_counts = [93, 81, 81, 81, 81, 81, 81, 81, 81, 81, 25] + query_counts = [64, 51, 51, 51, 51, 51, 51, 51, 51, 51, 21] ordered_course_ids = sorted([str(cid) for cid in (course_ids + [c.id for c in self.courses])]) self.clear_caches() diff --git a/lms/djangoapps/courseware/courses.py b/lms/djangoapps/courseware/courses.py index e1b005aae4..8a3266a12a 100644 --- a/lms/djangoapps/courseware/courses.py +++ b/lms/djangoapps/courseware/courses.py @@ -464,7 +464,9 @@ def get_courses(user, org=None, filter_=None): 'modes', queryset=CourseMode.objects.exclude(mode_slug__in=CourseMode.CREDIT_MODES), to_attr='selectable_modes', - ) + ), + ).select_related( + 'image_set' ) permission_name = configuration_helpers.get_value(