Fix all stylelint errors (#23920)

* Fix all stylelint errors

For any errors that fixing would require changing the output of the css disable stylelint for that line instead of modifying.

* Update quality.py

Make stylelint quality check pass when there are no errors

* Delete empty selectors
This commit is contained in:
Adam Butterworth
2020-05-06 16:07:14 -04:00
committed by GitHub
parent 485e36e44a
commit 42cc0d0145
130 changed files with 988 additions and 806 deletions

View File

@@ -10,6 +10,6 @@ body {
color: $gray-d3;
}
footer.primary{
footer.primary {
font-size: font-size(x-small);
}

View File

@@ -257,7 +257,8 @@ dl {
padding: 0 $baseline;
position: relative;
.mast, .metadata {
.mast,
.metadata {
@include clearfix();
position: relative;
@@ -383,11 +384,6 @@ dl {
font-weight: 600;
}
}
// page metadata/action bar
.metadata {
}
}
// +Layout - Basic Page Content
@@ -434,7 +430,8 @@ dl {
}
}
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -630,7 +627,8 @@ hr.divide {
// ====================
// UI - semantically hide text
.sr, .sr-only {
.sr,
.sr-only {
@extend %cont-text-sr;
}

View File

@@ -92,8 +92,8 @@ video {
padding: 0;
border: 0;
outline: 0;
font-size: 100%;
font: inherit;
font-size: 100%;
vertical-align: baseline;
}

View File

@@ -15,17 +15,3 @@
}
}
}
// ====================
// CASE: less than or equal to IE8
.lte8 {
}
// ====================
// CASE: less than or equal to IE7
.lte7 {
}

View File

@@ -4,19 +4,22 @@
@extend %ui-btn;
@extend %ui-btn-pill;
padding:($baseline/4) ($baseline/2);
padding: ($baseline/4) ($baseline/2);
border-width: 1px;
border-style: solid;
border-color: transparent;
text-align: center;
&:hover, &:active {
&:hover,
&:active {
@extend %ui-fake-link;
border-color: $gray-l3;
}
&.current, &.active, &.is-selected {
&.current,
&.active,
&.is-selected {
box-shadow: inset 0 1px 2px 1px $shadow-l1;
border-color: $gray-l3;
}
@@ -31,16 +34,19 @@
border-color: $white;
color: $gray-d1;
&:hover, &:active {
&:hover,
&:active {
background: $white;
color: $blue-s1;
}
&.current, &.active {
&.current,
&.active {
background: $white;
color: $gray-d4;
&:hover, &:active {
&:hover,
&:active {
color: $blue-s1;
}
}

View File

@@ -23,7 +23,8 @@
// ====================
// basic layout
.wrapper-l, .wrapper-r {
.wrapper-l,
.wrapper-r {
background: $white;
}
@@ -36,7 +37,11 @@
@include text-align(right);
}
.branding, .info-course, .nav-course, .nav-account, .nav-pitch {
.branding,
.info-course,
.nav-course,
.nav-account,
.nav-pitch {
box-sizing: border-box;
display: inline-block;
vertical-align: middle;
@@ -67,7 +72,7 @@
margin-right: 0;
}
.title{
.title {
@extend %ui-btn-dd-nav-primary;
@include transition(all $tmg-f2 ease-in-out 0s);
@@ -132,7 +137,6 @@
.nav-account-user {
.title {
max-width: ($baseline*10.5);
display: inline-block;
max-width: 84%;
overflow: hidden;

View File

@@ -1,7 +1,8 @@
@font-face {
font-family: 'CreativeCommons';
src: url('#{$static-path}/fonts/CreativeCommons/cc.eot');
src: url('#{$static-path}/fonts/CreativeCommons/cc.eot#iefix') format('embedded-opentype'),
src:
url('#{$static-path}/fonts/CreativeCommons/cc.eot#iefix') format('embedded-opentype'),
url('#{$static-path}/fonts/CreativeCommons/cc.woff') format('woff'),
url('#{$static-path}/fonts/CreativeCommons/cc.ttf') format('truetype'),
url('#{$static-path}/fonts/CreativeCommons/cc.svg#CreativeCommons') format('svg');

View File

@@ -219,6 +219,7 @@
color: $blue-d4;
}
}
.clipboard-button {
position: absolute;
right: 30px;

View File

@@ -54,7 +54,8 @@
}
}
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -109,7 +110,9 @@
}
}
label, input, textarea {
label,
input,
textarea {
display: block;
}
@@ -125,7 +128,8 @@
}
}
input, textarea {
input,
textarea {
@extend %t-copy-base;
height: 100%;
@@ -218,7 +222,8 @@
margin-right: 0;
}
input, textarea {
input,
textarea {
width: 100%;
}
}
@@ -251,7 +256,6 @@
margin: 0 0 ($baseline/4) 0;
color: $gray-d2;
}
}
}

View File

@@ -2,7 +2,8 @@
// ====================
.view-uploads {
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -210,7 +211,8 @@
text-align: left;
color: $gray;
.column-sort-link, .column-selected-link {
.column-sort-link,
.column-selected-link {
cursor: pointer;
color: $blue;
}
@@ -266,7 +268,7 @@
.nav-item {
&.reset-filter {
display:none;
display: none;
}
a {

View File

@@ -267,13 +267,16 @@
}
// location widget
.unit-location, .library-location {
.unit-location,
.library-location {
@extend %bar-module;
border-top: none;
.wrapper-unit-id, .wrapper-library-id {
.unit-id-value, .library-id-value {
.wrapper-unit-id,
.wrapper-library-id {
.unit-id-value,
.library-id-value {
@extend %status-value-base;
display: inline-block;
@@ -315,7 +318,8 @@
}
// typographical overrides (based off of outline-simple)
.section-header, .subsection-header {
.section-header,
.subsection-header {
line-height: 0;
margin-bottom: ($baseline/2);
}
@@ -377,7 +381,8 @@
}
.bc-container:not(.last) {
button, .parent-displayname {
button,
.parent-displayname {
text-decoration: underline;
color: $ui-link-color;
}
@@ -412,7 +417,8 @@
@include float(left);
}
.button-forward, .component {
.button-forward,
.component {
border: none;
}

View File

@@ -4,7 +4,8 @@
.view-export-git {
// UI: basic layout
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
float: left;

View File

@@ -4,7 +4,8 @@
.view-export {
// UI: basic layout
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -68,7 +69,8 @@
margin: ($baseline*2) 0;
.export-includes, .export-excludes {
.export-includes,
.export-excludes {
width: flex-grid(4, 9);
.item-detail {
@@ -210,7 +212,7 @@
// STATE: started
&.is-started {
.fa-warning {
.fa-warning {
visibility: hidden;
opacity: 0;
}
@@ -264,7 +266,8 @@
color: $red;
}
.status-detail .title, .status-detail .copy {
.status-detail .title,
.status-detail .copy {
color: $red;
}
}

View File

@@ -1,7 +1,8 @@
// studio - views - group-configurations
// ====================
.view-group-configurations {
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
@include float(left);
}
@@ -341,7 +342,9 @@
}
}
label, input, textarea {
label,
input,
textarea {
display: block;
}
@@ -361,7 +364,8 @@
}
//this section is borrowed from _account.scss - we should clean up and unify later
input, textarea {
input,
textarea {
@extend %t-copy-base;
height: 100%;
@@ -536,7 +540,7 @@
// specific group-type styles
.content-groups {
.collection-header{
.collection-header {
.title {
margin-bottom: 0;
}

View File

@@ -2,7 +2,8 @@
// ====================
.view-import {
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -233,7 +234,7 @@
// STATE: started
&.is-started {
.fa-warning {
.fa-warning {
visibility: hidden;
opacity: 0;
}
@@ -287,7 +288,8 @@
color: $red;
}
.status-detail .title, .status-detail .copy {
.status-detail .title,
.status-detail .copy {
color: $red;
}
}

View File

@@ -7,7 +7,9 @@
margin-bottom: 0;
}
.wrapper-content-header, .wrapper-content-features, .wrapper-content-cta {
.wrapper-content-header,
.wrapper-content-features,
.wrapper-content-cta {
@include box-sizing(border-box);
margin: 0;
@@ -33,21 +35,14 @@
margin-bottom: 0;
}
h1, h2, h3, h4, h5, h6 {
h1,
h2,
h3,
h4,
h5,
h6 {
color: $gray-d3;
}
h2 {
}
h3 {
}
h4 {
}
}
// welcome content
@@ -74,7 +69,8 @@
color: $white;
}
.wrapper-text-welcome, .logo {
.wrapper-text-welcome,
.logo {
display: inline-block;
}
@@ -98,7 +94,8 @@
border: 4px solid $black;
}
.arrow_box::after, .arrow_box::before {
.arrow_box::after,
.arrow_box::before {
top: 100%;
border: solid transparent;
content: " ";
@@ -133,10 +130,6 @@
}
.content-features {
.list-features {
}
// indiv features
.feature {
@include clearfix();

View File

@@ -46,7 +46,7 @@
overflow: auto;
}
.result{
.result {
box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.2);
margin-top: 15px;
padding: 15px 30px;

View File

@@ -11,7 +11,8 @@
// CASE: is-editable
// TODO: abstract out
.is-editable {
.incontext-editor-value, .incontext-editor-action-wrapper {
.incontext-editor-value,
.incontext-editor-action-wrapper {
vertical-align: top;
}
@@ -226,9 +227,9 @@
margin-left: $baseline / 2;
}
.status-release-label,
.status-highlights-enabled-label {
margin-right: ($baseline/4);
.status-release-label,
.status-highlights-enabled-label {
margin-right: ($baseline/4);
}
.status-highlights-enabled-value.button {
@@ -251,12 +252,6 @@
// outline
// --------------------
// UI: simple version of the outline
.outline-simple {
}
// UI: complex version of the outline
.outline-complex {
.outline-content {
@@ -270,10 +265,12 @@
&.is-collapsible {
// only select the current item's toggle expansion controls
&:nth-child(1) .ui-toggle-expansion, &:nth-child(1) .item-title {
&:nth-child(1) .ui-toggle-expansion,
&:nth-child(1) .item-title {
// STATE: hover/active
&:hover, &:active {
&:hover,
&:active {
color: $blue;
}
}
@@ -331,7 +328,8 @@
width: flex-grid(6, 9);
.icon, .wrapper-section-title {
.icon,
.wrapper-section-title {
display: inline-block;
vertical-align: top;
}
@@ -431,7 +429,8 @@
width: flex-grid(5, 9);
.icon, .wrapper-subsection-title {
.icon,
.wrapper-subsection-title {
display: inline-block;
vertical-align: top;
}
@@ -571,10 +570,6 @@
margin-bottom: $baseline;
}
.add-subsection {
}
.add-unit {
margin-left: $outline-indent-width;
}
@@ -716,7 +711,9 @@
// TODO: refactor the _forms.scss partial to allow for this area to inherit from it
label, input, textarea {
label,
input,
textarea {
display: block;
}
@@ -734,7 +731,8 @@
}
input, textarea {
input,
textarea {
@extend %t-copy-base;
@include transition(all $tmg-f2 ease-in-out 0s);
@@ -765,7 +763,8 @@
// CASE: select input
.field-select {
.label, .input {
.label,
.input {
display: inline-block;
vertical-align: middle;
}
@@ -816,7 +815,8 @@
text-transform: uppercase;
}
.outline-unit .unit-title, .outline-unit .unit-status {
.outline-unit .unit-title,
.outline-unit .unit-status {
display: inline-block;
vertical-align: middle;
}
@@ -832,7 +832,6 @@
text-align: right;
}
}
// it is the only element there
@@ -841,5 +840,4 @@
margin-bottom: 0;
}
}
}

View File

@@ -10,7 +10,8 @@
@include text-align(left);
@include direction();
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -71,11 +72,8 @@
// course details that should appear more like content than elements to change
.is-not-editable {
label {
}
input, textarea {
input,
textarea {
@extend %t-copy-lead1;
@extend %t-strong;
@@ -122,15 +120,6 @@
width: 100%;
}
// basic layout/elements
.title-2 {
}
.title-3 {
}
// in form -UI hints/tips/messages
.header-help {
margin: 0 0 $baseline 0;
@@ -183,27 +172,30 @@
.list-input {
@extend %cont-no-list;
.show-data{
.heading{
.show-data {
.heading {
border: 1px solid #e0e0e0;
padding: 5px 15px;
margin-top: 5px;
}
.div-grade-requirements{
.div-grade-requirements {
border: 1px solid #e0e0e0;
border-top: none;
padding: 10px 15px;
label{font-weight: 600;}
input#entrance-exam-minimum-score-pct{
label {
font-weight: 600;
}
input#entrance-exam-minimum-score-pct {
height: 40px;
font-size: 18px;
}
}
}
#heading-entrance-exam{
#heading-entrance-exam {
font-weight: 600;
}
@@ -229,7 +221,9 @@
}
}
label, input, textarea {
label,
input,
textarea {
display: block;
}
@@ -246,7 +240,8 @@
}
}
input, textarea {
input,
textarea {
@extend %t-copy-base;
@include placeholder($gray-l4);
@@ -254,12 +249,6 @@
padding: ($baseline/2);
&.long {
}
&.short {
}
&.error {
border-color: $red;
}
@@ -279,7 +268,7 @@
.minimum-grade-percentage-sign {
@include line-height(30);
padding-left: ($baseline/4);;
padding-left: ($baseline/4);
}
textarea.long {
@@ -354,7 +343,8 @@
}
.is-not-editable {
input, textarea {
input,
textarea {
padding: 0;
}
}
@@ -438,7 +428,7 @@
.list-actions {
box-shadow: inset 0 1px 1px $shadow-l1;
border-top: 1px solid $gray-l2;
padding: ($baseline/2);
padding: ($baseline/2);
background: $gray-l5;
.action-primary {
@@ -480,7 +470,8 @@
}
.is-not-editable {
input, textarea {
input,
textarea {
padding: 10px;
}
}
@@ -550,7 +541,9 @@
}
// specific fields - course image
#field-course-image, #field-banner-image, #field-video-thumbnail-image {
#field-course-image,
#field-banner-image,
#field-video-thumbnail-image {
.current-course-image {
margin-bottom: ($baseline/2);
padding: ($baseline/2) $baseline;
@@ -743,10 +736,6 @@
}
}
&.is-dragging {
}
.remove-button {
@extend %t-action5;
@@ -826,7 +815,6 @@
#field-course-minimum_grade_credit {
width: flex-grid(4, 9);
}
}
&.assignment-types {
@@ -1101,7 +1089,8 @@
}
}
.key, .value {
.key,
.value {
float: left;
margin: 0 0 ($baseline/2) 0;
}
@@ -1219,7 +1208,7 @@
}
.error-item-message {
width:100%;
width: 100%;
border: none;
resize: none;

View File

@@ -293,7 +293,8 @@
vertical-align: bottom;
}
&.action-duplicate, &.action-move {
&.action-duplicate,
&.action-move {
display: none;
}
}
@@ -315,7 +316,7 @@
.course-nav-item-header {
display: inline-block;
width:80%;
width: 80%;
.title {
@extend %t-title4;

View File

@@ -2,7 +2,8 @@
// ====================
.view-textbooks {
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -113,9 +114,7 @@
@extend %ui-btn-non;
}
}
}
}
&:hover .actions {
@@ -177,8 +176,6 @@
padding: ($baseline/5) $baseline;
text-transform: uppercase;
}
}
.copy {
@@ -187,12 +184,9 @@
margin: ($baseline) 0 ($baseline/2) 0;
color: $gray;
strong {
@extend %t-strong;
}
}
.chapters-fields,
@@ -217,7 +211,9 @@
}
}
label, input, textarea {
label,
input,
textarea {
display: block;
}
@@ -239,7 +235,8 @@
//this section is borrowed from _account.scss - we should clean up and unify later
input, textarea {
input,
textarea {
@extend %t-copy-base;
height: 100%;
@@ -331,7 +328,8 @@
position: relative;
input, textarea {
input,
textarea {
width: 100%;
}
@@ -343,7 +341,6 @@
@include right(0);
}
}
.action-close {

View File

@@ -112,7 +112,8 @@
padding: 20px;
}
ol, ul {
ol,
ul {
margin: 1em 0;
padding: 0 0 0 1em;
color: $body-color;

View File

@@ -4,7 +4,8 @@
.view-team {
// LAYOUT: page
.content-primary, .content-supplementary {
.content-primary,
.content-supplementary {
@include box-sizing(border-box);
}
@@ -32,7 +33,8 @@
// CASE: notice has actions {
&.has-actions {
.msg, .list-actions {
.msg,
.list-actions {
display: inline-block;
vertical-align: middle;
}
@@ -47,10 +49,6 @@
text-align: right;
margin-top: 0;
.action-item {
}
.action-primary {
@extend %btn-primary-green;
@@ -69,7 +67,10 @@
}
// ELEM: listing of users
.user-list, .user-item, .item-metadata, .item-actions {
.user-list,
.user-item,
.item-metadata,
.item-actions {
@include box-sizing(border-box);
}
@@ -88,7 +89,8 @@
margin-bottom: 0;
}
.item-metadata, .item-actions {
.item-metadata,
.item-actions {
display: inline-block;
vertical-align: middle;
}
@@ -133,7 +135,8 @@
@include margin-right(flex-gutter());
.user-username, .user-email {
.user-username,
.user-email {
display: inline-block;
vertical-align: middle;
}
@@ -220,20 +223,6 @@
color: inherit;
}
}
// STATE: hover
&:hover {
.user-username {
}
.user-email {
}
.item-actions {
}
}
}
}
}