From 41db8d8ec1cabd4b35f3c5fb84edef8695faabac Mon Sep 17 00:00:00 2001 From: aamir-khan Date: Tue, 2 Jun 2015 16:31:23 +0500 Subject: [PATCH] ECOM-1592: code refactoring --- openedx/core/djangoapps/credit/tasks.py | 8 ++++---- openedx/core/djangoapps/credit/tests/test_tasks.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/openedx/core/djangoapps/credit/tasks.py b/openedx/core/djangoapps/credit/tasks.py index 48affc1323..be27d7663b 100644 --- a/openedx/core/djangoapps/credit/tasks.py +++ b/openedx/core/djangoapps/credit/tasks.py @@ -136,13 +136,13 @@ def _is_credit_requirement(xblock): if not callable(getattr(xblock, "get_credit_requirement_namespace", None)): is_credit_requirement = False LOGGER.error( - "XBlock %v is marked as a credit requirement but does not " - "implement get_credit_requirement_namespace()", xblock + "XBlock %s is marked as a credit requirement but does not " + "implement get_credit_requirement_namespace()", unicode(xblock) ) if not callable(getattr(xblock, "get_credit_requirement_name", None)): is_credit_requirement = False LOGGER.error( - "XBlock %v is marked as a credit requirement but does not " - "implement get_credit_requirement_name()", xblock + "XBlock %s is marked as a credit requirement but does not " + "implement get_credit_requirement_name()", unicode(xblock) ) return is_credit_requirement diff --git a/openedx/core/djangoapps/credit/tests/test_tasks.py b/openedx/core/djangoapps/credit/tests/test_tasks.py index 1e9408503f..a0cbbae6a4 100644 --- a/openedx/core/djangoapps/credit/tests/test_tasks.py +++ b/openedx/core/djangoapps/credit/tests/test_tasks.py @@ -32,7 +32,7 @@ class TestTaskExecution(ModuleStoreTestCase): section = ItemFactory.create(parent=self.course, category='chapter', display_name='Test Section') subsection = ItemFactory.create(parent=section, category='sequential', display_name='Test Subsection') vertical = ItemFactory.create(parent=subsection, category='vertical', display_name='Test Unit') - reverification = ItemFactory.create( + ItemFactory.create( parent=vertical, category='edx-reverification-block', display_name='Test Verification Block'