requested changes for quality and performance

This commit is contained in:
Rene Sorel
2016-09-20 11:55:10 +02:00
parent a91b5f380c
commit 408bc223e5
3 changed files with 8 additions and 13 deletions

View File

@@ -72,13 +72,13 @@ class MobileAPITestCase(ModuleStoreTestCase, APITestCase):
self.login()
self.enroll(course_id)
def api_response(self, reverse_args=None, expected_response_code=200, qargs={}, **kwargs):
def api_response(self, reverse_args=None, expected_response_code=200, data=None, **kwargs):
"""
Helper method for calling endpoint, verifying and returning response.
If expected_response_code is None, doesn't verify the response' status_code.
"""
url = self.reverse_url(reverse_args, **kwargs)
response = self.url_method(url, qargs=qargs, **kwargs)
response = self.url_method(url, data=data, **kwargs)
if expected_response_code is not None:
self.assertEqual(response.status_code, expected_response_code)
return response
@@ -92,9 +92,9 @@ class MobileAPITestCase(ModuleStoreTestCase, APITestCase):
reverse_args.update({'username': kwargs.get('username', self.user.username)})
return reverse(self.REVERSE_INFO['name'], kwargs=reverse_args)
def url_method(self, url, qargs={}, **kwargs): # pylint: disable=unused-argument
def url_method(self, url, data=None, **kwargs): # pylint: disable=unused-argument
"""Base implementation that returns response from the GET method of the URL."""
return self.client.get(url, qargs)
return self.client.get(url, data=data)
class MobileAuthTestMixin(object):