From 4049db2d41db5e31bcfc5312bd5ab8346ca553a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9s=20Gonz=C3=A1lez?= <andres@aulasneo.com>
Date: Tue, 20 Sep 2022 16:37:05 -0300
Subject: [PATCH] fix: Refactor xss-lint exceptions that break the certificate
 share-in-facebook link (#30495)

* Remove xss-lint that break the certificate share in facebook link

* Refactor xss-lint in fb share link

* fix: Refactor xss-lint exceptions that break the certificate share-in-facebook link

Co-authored-by: EC2 Default User <ec2-user@ip-172-31-1-149.ec2.internal>
---
 lms/templates/certificates/_accomplishment-banner.html | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lms/templates/certificates/_accomplishment-banner.html b/lms/templates/certificates/_accomplishment-banner.html
index ab39759653..9e9b1c2cd3 100644
--- a/lms/templates/certificates/_accomplishment-banner.html
+++ b/lms/templates/certificates/_accomplishment-banner.html
@@ -50,12 +50,8 @@ from openedx.core.djangolib.js_utils import js_escaped_string
                     <h3 class="sr-only">${_("Print or share your certificate:")}</h3>
                     % if facebook_share_enabled:
                       <button class="action action-share-facebook btn-inverse btn-small icon-only" id="action-share-facebook"
-                         onclick="FaceBook.share({
-                          share_text: '${facebook_share_text | n, js_escaped_string}', ## xss-lint: disable=mako-invalid-html-filter
-                          share_link: '${share_url | n, js_escaped_string}', ## xss-lint: disable=mako-invalid-html-filter
-                          picture_link: '${full_course_image_url | n, js_escaped_string}', ## xss-lint: disable=mako-invalid-html-filter
-                          description: '${_('Click the link to see my certificate.') | n, js_escaped_string}' ## xss-lint: disable=mako-invalid-html-filter
-                          });">
+                        ## xss-lint: disable=mako-invalid-html-filter
+                        onclick="FaceBook.share({share_text: '${facebook_share_text | n, js_escaped_string}', share_link: '${share_url | n, js_escaped_string}', picture_link: '${full_course_image_url | n, js_escaped_string}', description: '${_('Click the link to see my certificate.') | n, js_escaped_string}'});">
                           <span class="icon fa fa-facebook-official" aria-hidden="true"></span>
                           <span class="action-label">${_("Post on Facebook")}</span>
                       </button>