Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: add a nontranslated status video field (#33939)

Browse Source
This commit is contained in:
ABBOUD Moncef
2024-05-13 15:58:01 +02:00
committed by GitHub
parent 15caa9746f
commit 3fa77ea44d
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cms/djangoapps/contentstore/video_storage_handlers.py
View File

@@ -173,9 +173,8 @@ class StatusDisplayStrings:
@staticmethod @staticmethod
def get(val_status): def get(val_status):
"""Map a VAL status string to a localized display string""" """Map a VAL status string to a display string"""
# pylint: disable=translation-of-non-string return StatusDisplayStrings._STATUS_MAP.get(val_status, StatusDisplayStrings._UNKNOWN)
return _(StatusDisplayStrings._STATUS_MAP.get(val_status, StatusDisplayStrings._UNKNOWN))
def handle_videos(request, course_key_string, edx_video_id=None): def handle_videos(request, course_key_string, edx_video_id=None):
@@ -657,7 +656,10 @@ def _get_videos(course, pagination_conf=None):
language_code=language_code, language_code=language_code,
) )
# Convert the video status. # Convert the video status.
video['status'] = convert_video_status(video, is_video_encodes_ready) # Legacy frontend expects the status to be translated unlike MFEs which handle translation themselves.
video['status_nontranslated'] = convert_video_status(video, is_video_encodes_ready)
# pylint: disable=translation-of-non-string
video['status'] = _(video['status_nontranslated'])
return videos, pagination_context return videos, pagination_context
@@ -675,7 +677,7 @@ def _get_index_videos(course, pagination_conf=None):
""" """
course_id = str(course.id) course_id = str(course.id)
attrs = [ attrs = [
'edx_video_id', 'client_video_id', 'created', 'duration', 'edx_video_id', 'client_video_id', 'created', 'duration', 'status_nontranslated',
'status', 'courses', 'encoded_videos', 'transcripts', 'transcription_status', 'status', 'courses', 'encoded_videos', 'transcripts', 'transcription_status',
'transcript_urls', 'error_description' 'transcript_urls', 'error_description'
] ]

9
cms/djangoapps/contentstore/views/tests/test_videos.py
View File

@@ -367,6 +367,7 @@ class VideosHandlerTestCase(
'created', 'created',
'duration', 'duration',
'status', 'status',
'status_nontranslated',
'course_video_image_url', 'course_video_image_url',
'file_size', 'file_size',
'download_link', 'download_link',
@@ -388,8 +389,8 @@ class VideosHandlerTestCase(
( (
[ [
'edx_video_id', 'client_video_id', 'created', 'duration', 'edx_video_id', 'client_video_id', 'created', 'duration',
'status', 'course_video_image_url', 'file_size', 'download_link', 'status', 'status_nontranslated', 'course_video_image_url', 'file_size',
'transcripts', 'transcription_status', 'transcript_urls', 'download_link', 'transcripts', 'transcription_status', 'transcript_urls',
'error_description' 'error_description'
], ],
[ [
@@ -406,8 +407,8 @@ class VideosHandlerTestCase(
( (
[ [
'edx_video_id', 'client_video_id', 'created', 'duration', 'edx_video_id', 'client_video_id', 'created', 'duration',
'status', 'course_video_image_url', 'file_size', 'download_link', 'status', 'status_nontranslated', 'course_video_image_url', 'file_size',
'transcripts', 'transcription_status', 'transcript_urls', 'download_link', 'transcripts', 'transcription_status', 'transcript_urls',
'error_description' 'error_description'
], ],
[ [