From ba491195e6b1c5b0b1b6a524ceb1dd7953ae7161 Mon Sep 17 00:00:00 2001 From: Andy Armstrong Date: Thu, 2 Oct 2014 11:54:23 -0400 Subject: [PATCH 1/2] Update final text strings & readthedoc URL TNL-401 --- common/lib/xmodule/xmodule/course_module.py | 2 +- .../coffee/spec/discussion/discussion_spec_helper.coffee | 2 +- lms/templates/discussion/_underscore_templates.html | 2 +- .../instructor/instructor_dashboard_2/cohort-editor.underscore | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/common/lib/xmodule/xmodule/course_module.py b/common/lib/xmodule/xmodule/course_module.py index 37a678b1d4..35acd24931 100644 --- a/common/lib/xmodule/xmodule/course_module.py +++ b/common/lib/xmodule/xmodule/course_module.py @@ -266,7 +266,7 @@ class CourseFields(object): ) cohort_config = Dict( display_name=_("Cohort Configuration"), - help=_("Cohorts are not currently supported by edX."), + help=_("Enter policy keys and values to enable the cohort feature, define automated student assignment to groups, or identify any course-wide discussion topics as private to cohort members."), scope=Scope.settings ) is_new = Boolean( diff --git a/common/static/coffee/spec/discussion/discussion_spec_helper.coffee b/common/static/coffee/spec/discussion/discussion_spec_helper.coffee index f7d6835363..a6071854cd 100644 --- a/common/static/coffee/spec/discussion/discussion_spec_helper.coffee +++ b/common/static/coffee/spec/discussion/discussion_spec_helper.coffee @@ -331,7 +331,7 @@ browser and pasting the output. When that file changes, this one should be rege <% }); %>
- Instructors can set whether a post in a cohorted topic is visible to all cohorts or only to a specific cohort. + Discussion admins and moderators can make their posts visible to all students or specify a single cohort group.
<% } %> diff --git a/lms/templates/discussion/_underscore_templates.html b/lms/templates/discussion/_underscore_templates.html index cf9ca04d65..aefc02a5e4 100644 --- a/lms/templates/discussion/_underscore_templates.html +++ b/lms/templates/discussion/_underscore_templates.html @@ -421,7 +421,7 @@ ${'<% }); %>'}
- ${_("Instructors can set whether a post in a cohorted topic is visible to all cohorts or only to a specific cohort.")} + ${_("Discussion admins and moderators can make their posts visible to all students or specify a single cohort group.")}
${'<% } %>'} diff --git a/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore b/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore index 8b22401b70..9c7c37fad1 100644 --- a/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore +++ b/lms/templates/instructor/instructor_dashboard_2/cohort-editor.underscore @@ -17,10 +17,11 @@
<% if (cohort.get('assignment_type') == "none") { %> <%= gettext("Students are added to this group only when you provide their email addresses or usernames on this page.") %> + <%= gettext("What does this mean?") %> <% } else { %> <%= gettext("Students are added to this group automatically.") %> + <%= gettext("What does this mean?") %> <% } %> - <%= gettext("What does this mean?") %>
<% if (advanced_settings_url != "None") { %> From 7be11b47da17caaba5a228e86b5655b5f50bffb9 Mon Sep 17 00:00:00 2001 From: Andy Armstrong Date: Thu, 2 Oct 2014 13:07:58 -0400 Subject: [PATCH 2/2] Address PR review comments --- .../static/coffee/spec/discussion/discussion_spec_helper.coffee | 2 +- lms/templates/discussion/_underscore_templates.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/static/coffee/spec/discussion/discussion_spec_helper.coffee b/common/static/coffee/spec/discussion/discussion_spec_helper.coffee index a6071854cd..a957570696 100644 --- a/common/static/coffee/spec/discussion/discussion_spec_helper.coffee +++ b/common/static/coffee/spec/discussion/discussion_spec_helper.coffee @@ -331,7 +331,7 @@ browser and pasting the output. When that file changes, this one should be rege <% }); %>
- Discussion admins and moderators can make their posts visible to all students or specify a single cohort group. + Discussion admins, moderators, and TAs can make their posts visible to all students or specify a single cohort group.
<% } %> diff --git a/lms/templates/discussion/_underscore_templates.html b/lms/templates/discussion/_underscore_templates.html index aefc02a5e4..8cdd031b60 100644 --- a/lms/templates/discussion/_underscore_templates.html +++ b/lms/templates/discussion/_underscore_templates.html @@ -421,7 +421,7 @@ ${'<% }); %>'}
- ${_("Discussion admins and moderators can make their posts visible to all students or specify a single cohort group.")} + ${_("Discussion admins, moderators, and TAs can make their posts visible to all students or specify a single cohort group.")}
${'<% } %>'}