fixup! review comments

This commit is contained in:
Nimisha Asthagiri
2016-11-21 14:07:51 -05:00
parent 2aac2b9d86
commit 3bb5617abd
3 changed files with 12 additions and 13 deletions

View File

@@ -120,7 +120,7 @@ def grader_from_conf(conf):
This creates a CourseGrader from a configuration (such as in course_settings.py).
The conf can simply be an instance of CourseGrader, in which case no work is done.
More commonly, the conf is a list of dictionaries. A WeightedSubsectionsGrader
with AssignmentFormatGrader's will be generated. Every dictionary should contain
with AssignmentFormatGraders will be generated. Every dictionary should contain
the parameters for making an AssignmentFormatGrader, in addition to a 'weight' key.
"""
if isinstance(conf, CourseGrader):

View File

@@ -282,18 +282,18 @@ class GraderTest(unittest.TestCase):
self.assertEqual(len(graded['section_breakdown']), 12 + 1)
@ddt.data(
# empty
(
# empty
{},
u"Configuration has no appropriate grader class."
),
# no min_count
(
# no min_count
{'type': "Homework", 'drop_count': 0},
u"Configuration has no appropriate grader class."
),
# no drop_count
(
# no drop_count
{'type': "Homework", 'min_count': 0},
u"__init__() takes at least 4 arguments (3 given)"
),