From 87a7e879aec1786357fc888fe48323c3bc9d898b Mon Sep 17 00:00:00 2001 From: salman2013 Date: Wed, 5 Jun 2024 17:04:57 +0500 Subject: [PATCH 1/4] chore: add workflow to find dependencies --- .../workflows/check_python_dependencies.yml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 .github/workflows/check_python_dependencies.yml diff --git a/.github/workflows/check_python_dependencies.yml b/.github/workflows/check_python_dependencies.yml new file mode 100644 index 0000000000..234074283c --- /dev/null +++ b/.github/workflows/check_python_dependencies.yml @@ -0,0 +1,47 @@ +name: Check Python Dependencies + +on: + pull_request: + +defaults: + run: + shell: bash + +jobs: + check_dependencies: + runs-on: ubuntu-latest + + strategy: + matrix: + python-version: ["3.12"] + + steps: + - name: Checkout Repository + uses: actions/checkout@v4 + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + + - name: Install repo-tools + run: pip install git+https://github.com/salman2013/repo-tools.git@salman/add-script-for-python-dependencies + + - name: Install requirements parser module + run: pip install requirements-parser + + - name: Install setuptool + run: pip install setuptools + + - name: Run Python script + run: | + find_python_dependencies \ + --req-file requirements/edx/base.txt \ + --req-file requirements/edx/testing.txt \ + --ignore https://github.com/edx/codejail-includes \ + --ignore https://github.com/edx/braze-client \ + --ignore https://github.com/edx/edx-name-affirmation \ + --ignore https://github.com/mitodl/edx-sga \ + --ignore https://github.com/edx/token-utils \ + --ignore https://github.com/open-craft/xblock-poll + From 7ecf49e8cabc4c2c398c3d8df92a7d0c5b62a2e9 Mon Sep 17 00:00:00 2001 From: salman2013 Date: Mon, 10 Jun 2024 16:49:01 +0500 Subject: [PATCH 2/4] fix: fix the comments as per PR review --- .github/workflows/check_python_dependencies.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/check_python_dependencies.yml b/.github/workflows/check_python_dependencies.yml index 234074283c..a9dba1b3a0 100644 --- a/.github/workflows/check_python_dependencies.yml +++ b/.github/workflows/check_python_dependencies.yml @@ -25,14 +25,8 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install repo-tools - run: pip install git+https://github.com/salman2013/repo-tools.git@salman/add-script-for-python-dependencies + run: pip install edx-repo-tools[find_dependencies] - - name: Install requirements parser module - run: pip install requirements-parser - - - name: Install setuptool - run: pip install setuptools - - name: Run Python script run: | find_python_dependencies \ From 6a526bb1d724fa49270df128da46506b3c065cdc Mon Sep 17 00:00:00 2001 From: salman2013 Date: Mon, 10 Jun 2024 16:56:52 +0500 Subject: [PATCH 3/4] fix: fix test cases --- .github/workflows/check_python_dependencies.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/check_python_dependencies.yml b/.github/workflows/check_python_dependencies.yml index a9dba1b3a0..698948167e 100644 --- a/.github/workflows/check_python_dependencies.yml +++ b/.github/workflows/check_python_dependencies.yml @@ -26,6 +26,9 @@ jobs: - name: Install repo-tools run: pip install edx-repo-tools[find_dependencies] + + - name: Install setuptool + run: pip install setuptools - name: Run Python script run: | From 35f6f5041d1d63e961632e8d2deda6cbe9f22967 Mon Sep 17 00:00:00 2001 From: salman2013 Date: Mon, 10 Jun 2024 17:10:05 +0500 Subject: [PATCH 4/4] fix: code improvement as per PR reivew comment --- .github/workflows/check_python_dependencies.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/check_python_dependencies.yml b/.github/workflows/check_python_dependencies.yml index 698948167e..85a4e796ce 100644 --- a/.github/workflows/check_python_dependencies.yml +++ b/.github/workflows/check_python_dependencies.yml @@ -3,10 +3,6 @@ name: Check Python Dependencies on: pull_request: -defaults: - run: - shell: bash - jobs: check_dependencies: runs-on: ubuntu-latest