From 70d78fc4f9536a3c86ebef15d3d13ffa3b55d095 Mon Sep 17 00:00:00 2001 From: Omar Al-Ithawi Date: Sun, 2 Apr 2017 18:27:55 +0300 Subject: [PATCH 1/2] RTL fixes for ul, ol, h1, h3-h6 in the HTML xmodule --- common/lib/xmodule/xmodule/css/html/display.scss | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/common/lib/xmodule/xmodule/css/html/display.scss b/common/lib/xmodule/xmodule/css/html/display.scss index 8c81516a64..27e358cb3b 100644 --- a/common/lib/xmodule/xmodule/css/html/display.scss +++ b/common/lib/xmodule/xmodule/css/html/display.scss @@ -7,7 +7,7 @@ h1 { color: $baseFontColor; font: normal 2em/1.4em $sans-serif; letter-spacing: 1px; - margin: 0 0 1.416em 0; + @include margin(0, 0, 1.416em, 0); } h2 { @@ -19,7 +19,7 @@ h2 { } h3, h4, h5, h6 { - margin: 0 0 ($baseline/2) 0; + @include margin(0, 0, ($baseline/2), 0); font-weight: 600; } @@ -71,8 +71,9 @@ blockquote { } ol, ul { + // Using the lower level Bi App Sass mixin to avoid @padding conflicts with bourbon. + @include bi-app-compact(padding, 0, 0, 0, 1em); margin: 1em 0; - padding: 0 0 0 1em; color: $baseFontColor; li { From 4f80790f5650da521ebd76b6211f5fa5d83ada34 Mon Sep 17 00:00:00 2001 From: Omar Al-Ithawi Date: Sun, 2 Apr 2017 18:28:03 +0300 Subject: [PATCH 2/2] RTL fixes for ul, ol, legend elements in the lms _reset.scss --- lms/static/sass/base/_reset.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lms/static/sass/base/_reset.scss b/lms/static/sass/base/_reset.scss index 11a4fd1ff8..c15a10c1bf 100644 --- a/lms/static/sass/base/_reset.scss +++ b/lms/static/sass/base/_reset.scss @@ -29,7 +29,7 @@ sub, sup { font-size: 75%; line-height: 0; position: relative; vertical-align: b sup { top: -0.5em; } sub { bottom: -0.25em; } -ul, ol { margin: 1em 0; padding: 0 0 0 40px; } +ul, ol { @include padding(0, 0, 0, 40px); margin: 1em 0; } dd { margin: 0 0 0 40px; } nav ul, nav ol { list-style: none; list-style-image: none; margin: 0; padding: 0; }