From cc0d227928a0a95ecc0e6c9a5ed87a29f3baaf58 Mon Sep 17 00:00:00 2001 From: Greg Price Date: Tue, 11 Mar 2014 16:41:04 -0400 Subject: [PATCH] Improve robustness of bok choy discussion tests A test failed because an element disappeared between the evaluation of the clauses of a conjunction, so rewrite to make the conjunction unnecessary. --- common/test/acceptance/pages/lms/discussion_single_thread.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/common/test/acceptance/pages/lms/discussion_single_thread.py b/common/test/acceptance/pages/lms/discussion_single_thread.py index e71d60d0b2..b3c1d6c44e 100644 --- a/common/test/acceptance/pages/lms/discussion_single_thread.py +++ b/common/test/acceptance/pages/lms/discussion_single_thread.py @@ -67,10 +67,7 @@ class DiscussionSingleThreadPage(CoursePage): )) def _is_element_visible(self, selector): - return ( - self.is_css_present(selector) and - self.css_map(selector, lambda el: el.visible)[0] - ) + return any(self.css_map(selector, lambda el: el.visible)) def is_response_editor_visible(self, response_id): """Returns true if the response editor is present, false otherwise"""