diff --git a/openedx/core/djangoapps/programs/admin.py b/openedx/core/djangoapps/programs/admin.py index 97be43e64b..64da72dca3 100644 --- a/openedx/core/djangoapps/programs/admin.py +++ b/openedx/core/djangoapps/programs/admin.py @@ -7,7 +7,7 @@ from django.contrib import admin from openedx.core.djangoapps.programs.models import ProgramsApiConfig -class ProgramsApiConfigAdmin(ConfigurationModelAdmin): # pylint: disable=missing-docstring +class ProgramsApiConfigAdmin(ConfigurationModelAdmin): pass diff --git a/openedx/core/djangoapps/programs/management/commands/backpopulate_program_credentials.py b/openedx/core/djangoapps/programs/management/commands/backpopulate_program_credentials.py index 2d2b7866b8..ee4ddccfe2 100644 --- a/openedx/core/djangoapps/programs/management/commands/backpopulate_program_credentials.py +++ b/openedx/core/djangoapps/programs/management/commands/backpopulate_program_credentials.py @@ -7,7 +7,7 @@ from django.core.management import BaseCommand from django.db.models import Q from opaque_keys.edx.keys import CourseKey -from lms.djangoapps.certificates.models import CertificateStatuses, GeneratedCertificate # pylint: disable=import-error +from lms.djangoapps.certificates.models import CertificateStatuses, GeneratedCertificate from course_modes.models import CourseMode from openedx.core.djangoapps.catalog.utils import get_programs from openedx.core.djangoapps.programs.tasks.v1.tasks import award_program_certificates diff --git a/openedx/core/djangoapps/programs/tasks/v1/tasks.py b/openedx/core/djangoapps/programs/tasks/v1/tasks.py index 2d3fac8265..c9e38177db 100644 --- a/openedx/core/djangoapps/programs/tasks/v1/tasks.py +++ b/openedx/core/djangoapps/programs/tasks/v1/tasks.py @@ -3,7 +3,7 @@ This file contains celery tasks for programs-related functionality. """ from celery import task from celery.exceptions import MaxRetriesExceededError -from celery.utils.log import get_task_logger # pylint: disable=no-name-in-module, import-error +from celery.utils.log import get_task_logger from django.conf import settings from django.contrib.auth.models import User from django.contrib.sites.models import Site @@ -148,7 +148,7 @@ def award_program_certificates(self, username): # Determine which program certificates the user has already been awarded, if any. existing_program_uuids = get_certified_programs(student) - except Exception as exc: # pylint: disable=broad-except + except Exception as exc: LOGGER.exception('Failed to determine program certificates to be awarded for user %s', username) raise self.retry(exc=exc, countdown=countdown, max_retries=MAX_RETRIES) @@ -164,7 +164,7 @@ def award_program_certificates(self, username): credentials_client = get_credentials_api_client( User.objects.get(username=settings.CREDENTIALS_SERVICE_USERNAME), ) - except Exception as exc: # pylint: disable=broad-except + except Exception as exc: LOGGER.exception('Failed to create a credentials API client to award program certificates') # Retry because a misconfiguration could be fixed raise self.retry(exc=exc, countdown=countdown, max_retries=MAX_RETRIES) diff --git a/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py b/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py index 667f9ed565..948fc890f6 100644 --- a/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py +++ b/openedx/core/djangoapps/programs/tasks/v1/tests/test_tasks.py @@ -121,7 +121,7 @@ class AwardProgramCertificatesTestCase(CatalogIntegrationMixin, CredentialsApiCo self.catalog_integration = self.create_catalog_integration() ClientFactory.create(name='credentials') - UserFactory.create(username=settings.CREDENTIALS_SERVICE_USERNAME) # pylint: disable=no-member + UserFactory.create(username=settings.CREDENTIALS_SERVICE_USERNAME) def test_completion_check( self, @@ -264,7 +264,7 @@ class AwardProgramCertificatesTestCase(CatalogIntegrationMixin, CredentialsApiCo def test_retry_on_programs_api_errors( self, mock_get_completed_programs, - *_mock_helpers # pylint: disable=unused-argument + *_mock_helpers ): """ Ensures that any otherwise-unhandled errors that arise while trying diff --git a/openedx/core/djangoapps/programs/tests/factories.py b/openedx/core/djangoapps/programs/tests/factories.py index b541d5fc26..efe7b11336 100644 --- a/openedx/core/djangoapps/programs/tests/factories.py +++ b/openedx/core/djangoapps/programs/tests/factories.py @@ -1,5 +1,5 @@ """Factories for generating fake program-related data.""" -# pylint: disable=missing-docstring, invalid-name +# pylint: disable=missing-docstring import factory diff --git a/openedx/core/djangoapps/programs/tests/test_backpopulate_program_credentials.py b/openedx/core/djangoapps/programs/tests/test_backpopulate_program_credentials.py index 6b93d85e49..44f20cceae 100644 --- a/openedx/core/djangoapps/programs/tests/test_backpopulate_program_credentials.py +++ b/openedx/core/djangoapps/programs/tests/test_backpopulate_program_credentials.py @@ -4,7 +4,7 @@ import mock from django.core.management import call_command from django.test import TestCase -from lms.djangoapps.certificates.models import CertificateStatuses # pylint: disable=import-error +from lms.djangoapps.certificates.models import CertificateStatuses from course_modes.models import CourseMode from lms.djangoapps.certificates.api import MODES from lms.djangoapps.certificates.tests.factories import GeneratedCertificateFactory diff --git a/openedx/core/djangoapps/programs/tests/test_utils.py b/openedx/core/djangoapps/programs/tests/test_utils.py index 374c34c228..ee44542e19 100644 --- a/openedx/core/djangoapps/programs/tests/test_utils.py +++ b/openedx/core/djangoapps/programs/tests/test_utils.py @@ -1,5 +1,4 @@ """Tests covering Programs utilities.""" -# pylint: disable=no-member import datetime import json import uuid diff --git a/openedx/core/djangoapps/safe_sessions/middleware.py b/openedx/core/djangoapps/safe_sessions/middleware.py index 7ba898af03..670cf459dd 100644 --- a/openedx/core/djangoapps/safe_sessions/middleware.py +++ b/openedx/core/djangoapps/safe_sessions/middleware.py @@ -367,7 +367,7 @@ class SafeSessionMiddleware(SessionMiddleware): # conditionally set the log level. log_func = log.debug if request.user.id is None else log.warning log_func( - "SafeCookieData user at request '{0}' does not match user at response: '{1}'".format( # pylint: disable=logging-format-interpolation + "SafeCookieData user at request '{0}' does not match user at response: '{1}'".format( request.safe_cookie_verified_user_id, request.user.id, ), @@ -409,7 +409,7 @@ class SafeSessionMiddleware(SessionMiddleware): # django 1.8, replace the implementation of this method # with: # request.session[SESSION_KEY] = user.id - request.session[SESSION_KEY] = user._meta.pk.value_to_string(user) # pylint: disable=protected-access + request.session[SESSION_KEY] = user._meta.pk.value_to_string(user) @staticmethod def update_with_safe_session_cookie(cookies, user_id): diff --git a/openedx/core/djangoapps/safe_sessions/tests/test_middleware.py b/openedx/core/djangoapps/safe_sessions/tests/test_middleware.py index 452ca25c9e..2f4a398ffe 100644 --- a/openedx/core/djangoapps/safe_sessions/tests/test_middleware.py +++ b/openedx/core/djangoapps/safe_sessions/tests/test_middleware.py @@ -1,5 +1,3 @@ -# pylint: disable=no-member -# pylint: disable=protected-access """ Unit tests for SafeSessionMiddleware """ diff --git a/openedx/core/djangoapps/schedules/admin.py b/openedx/core/djangoapps/schedules/admin.py index 2658bd5c65..86c89de673 100644 --- a/openedx/core/djangoapps/schedules/admin.py +++ b/openedx/core/djangoapps/schedules/admin.py @@ -96,7 +96,7 @@ class CourseIdFilter(admin.SimpleListFilter): else: return queryset.filter(enrollment__course_id=value) - def choices(self, changelist): # pylint: disable=unused-argument + def choices(self, changelist): yield { 'selected': self.value() is None, 'value': None, diff --git a/openedx/core/djangoapps/schedules/management/commands/setup_models_to_send_test_emails.py b/openedx/core/djangoapps/schedules/management/commands/setup_models_to_send_test_emails.py index 3fad828d71..85c3165d5c 100644 --- a/openedx/core/djangoapps/schedules/management/commands/setup_models_to_send_test_emails.py +++ b/openedx/core/djangoapps/schedules/management/commands/setup_models_to_send_test_emails.py @@ -61,7 +61,7 @@ class Command(BaseCommand): max_org_sequence_id = max(int(course.org[4:]) for course in courses if course.org.startswith('org.')) XMODULE_FACTORY_LOCK.enable() - CourseFactory.reset_sequence(max_org_sequence_id + 1, force=True) # pylint: disable=no-member + CourseFactory.reset_sequence(max_org_sequence_id + 1, force=True) course = CourseFactory.create( start=datetime.datetime.today() - datetime.timedelta(days=30), end=datetime.datetime.today() + datetime.timedelta(days=30), diff --git a/openedx/core/djangoapps/schedules/management/commands/tests/test_send_course_update.py b/openedx/core/djangoapps/schedules/management/commands/tests/test_send_course_update.py index 04bb0c5c9a..df3dfb7c0c 100644 --- a/openedx/core/djangoapps/schedules/management/commands/tests/test_send_course_update.py +++ b/openedx/core/djangoapps/schedules/management/commands/tests/test_send_course_update.py @@ -1,7 +1,6 @@ """ Tests for send_course_update management command. """ -# pylint: disable=no-member import ddt from mock import patch, _is_started from unittest import skipUnless @@ -88,7 +87,7 @@ class TestSendCourseUpdate(ScheduleUpsellTestMixin, ScheduleSendEmailTestMixin, enrollment.schedule.save() with patch.object(tasks, 'ace') as mock_ace: - self.task().apply(kwargs=dict( # pylint: disable=no-value-for-parameter + self.task().apply(kwargs=dict( site_id=self.site_config.site.id, target_day_str=serialize(target_day), day_offset=offset, diff --git a/openedx/core/djangoapps/schedules/tasks.py b/openedx/core/djangoapps/schedules/tasks.py index 24a43ae59f..dcc796dc53 100644 --- a/openedx/core/djangoapps/schedules/tasks.py +++ b/openedx/core/djangoapps/schedules/tasks.py @@ -49,7 +49,7 @@ def update_course_schedules(self, **kwargs): start=new_start_date, upgrade_deadline=new_upgrade_deadline ) - except Exception as exc: # pylint: disable=broad-except + except Exception as exc: if not isinstance(exc, KNOWN_RETRY_ERRORS): LOG.exception("Unexpected failure: task id: %s, kwargs=%s".format(self.request.id, kwargs)) raise self.retry(kwargs=kwargs, exc=exc) diff --git a/openedx/core/djangoapps/site_configuration/models.py b/openedx/core/djangoapps/site_configuration/models.py index fcbf032ba9..295b267aeb 100644 --- a/openedx/core/djangoapps/site_configuration/models.py +++ b/openedx/core/djangoapps/site_configuration/models.py @@ -52,7 +52,7 @@ class SiteConfiguration(models.Model): """ if self.enabled: try: - return self.values.get(name, default) # pylint: disable=no-member + return self.values.get(name, default) except AttributeError as error: logger.exception('Invalid JSON data. \n [%s]', error) else: diff --git a/openedx/core/djangoapps/site_configuration/tests/test_middleware.py b/openedx/core/djangoapps/site_configuration/tests/test_middleware.py index 48277a4f7b..91509be26d 100644 --- a/openedx/core/djangoapps/site_configuration/tests/test_middleware.py +++ b/openedx/core/djangoapps/site_configuration/tests/test_middleware.py @@ -26,7 +26,6 @@ from openedx.core.djangolib.testing.utils import skip_unless_lms # NOTE: We set SESSION_SAVE_EVERY_REQUEST to True in order to make sure # Sessions are always started on every request -# pylint: disable=no-member, protected-access @ddt.ddt @override_settings(SESSION_SAVE_EVERY_REQUEST=True) @skip_unless_lms @@ -95,7 +94,6 @@ class SessionCookieDomainMicrositeOverrideTests(DatabaseMicrositeTestCase): # NOTE: We set SESSION_SAVE_EVERY_REQUEST to True in order to make sure # Sessions are always started on every request -# pylint: disable=no-member, protected-access @override_settings(SESSION_SAVE_EVERY_REQUEST=True) class SessionCookieDomainSiteConfigurationOverrideTests(TestCase): """ diff --git a/openedx/core/djangoapps/theming/management/commands/compile_sass.py b/openedx/core/djangoapps/theming/management/commands/compile_sass.py index 5b3f9640fa..1f1ad6bb2f 100644 --- a/openedx/core/djangoapps/theming/management/commands/compile_sass.py +++ b/openedx/core/djangoapps/theming/management/commands/compile_sass.py @@ -131,7 +131,7 @@ class Command(BaseCommand): if options.get("themes", None) and not is_comprehensive_theming_enabled(): # log a warning message to let the user know that asset compilation for themes is skipped self.stdout.write( - self.style.WARNING( # pylint: disable=no-member + self.style.WARNING( "Skipping theme asset compilation: enable theming to process themed assets" ), ) diff --git a/openedx/core/djangoapps/theming/tests/test_theme_locales.py b/openedx/core/djangoapps/theming/tests/test_theme_locales.py index 3cc7bc4e53..b79b2209b3 100644 --- a/openedx/core/djangoapps/theming/tests/test_theme_locales.py +++ b/openedx/core/djangoapps/theming/tests/test_theme_locales.py @@ -18,7 +18,7 @@ class TestComprehensiveThemeLocale(TestCase): """ test comprehensive theming paths in settings. """ - self.assertIn(settings.REPO_ROOT / 'themes/conf/locale', settings.LOCALE_PATHS) # pylint: disable=no-member + self.assertIn(settings.REPO_ROOT / 'themes/conf/locale', settings.LOCALE_PATHS) def test_theme_locale_path_exist(self): """ diff --git a/openedx/core/djangoapps/user_api/accounts/image_helpers.py b/openedx/core/djangoapps/user_api/accounts/image_helpers.py index 648e6e3dd1..a1c46c46e5 100644 --- a/openedx/core/djangoapps/user_api/accounts/image_helpers.py +++ b/openedx/core/djangoapps/user_api/accounts/image_helpers.py @@ -49,7 +49,7 @@ def _get_profile_image_urls(name, storage, file_extension=PROFILE_IMAGE_FILE_EXT Returns a dict containing the urls for a complete set of profile images, keyed by "friendly" name (e.g. "full", "large", "medium", "small"). """ - def _make_url(size): # pylint: disable=missing-docstring + def _make_url(size): url = storage.url( _get_profile_image_filename(name, size, file_extension=file_extension) ) diff --git a/openedx/core/djangoapps/user_api/accounts/tests/test_permissions.py b/openedx/core/djangoapps/user_api/accounts/tests/test_permissions.py index 6a6478a9af..94d46e9728 100644 --- a/openedx/core/djangoapps/user_api/accounts/tests/test_permissions.py +++ b/openedx/core/djangoapps/user_api/accounts/tests/test_permissions.py @@ -28,7 +28,7 @@ class CanDeactivateUserTest(TestCase): app_label='student' ) ) - user.user_permissions.add(permission) # pylint: disable=no-member + user.user_permissions.add(permission) self.request.user = user result = CanDeactivateUser().has_permission(self.request, None) diff --git a/openedx/core/djangoapps/user_api/api.py b/openedx/core/djangoapps/user_api/api.py index 68c7cff5b6..4a321347b0 100644 --- a/openedx/core/djangoapps/user_api/api.py +++ b/openedx/core/djangoapps/user_api/api.py @@ -451,7 +451,7 @@ class RegistrationFormFactory(object): error_msg = accounts.REQUIRED_FIELD_LEVEL_OF_EDUCATION_MSG # The labels are marked for translation in UserProfile model definition. - options = [(name, _(label)) for name, label in UserProfile.LEVEL_OF_EDUCATION_CHOICES] # pylint: disable=translation-of-non-string + options = [(name, _(label)) for name, label in UserProfile.LEVEL_OF_EDUCATION_CHOICES] form_desc.add_field( "level_of_education", label=education_level_label, @@ -476,7 +476,7 @@ class RegistrationFormFactory(object): gender_label = _(u"Gender") # The labels are marked for translation in UserProfile model definition. - options = [(name, _(label)) for name, label in UserProfile.GENDER_CHOICES] # pylint: disable=translation-of-non-string + options = [(name, _(label)) for name, label in UserProfile.GENDER_CHOICES] form_desc.add_field( "gender", label=gender_label, diff --git a/openedx/core/djangoapps/user_api/helpers.py b/openedx/core/djangoapps/user_api/helpers.py index 40db7094cd..66f0a9dfc9 100644 --- a/openedx/core/djangoapps/user_api/helpers.py +++ b/openedx/core/djangoapps/user_api/helpers.py @@ -100,7 +100,7 @@ def require_post_params(required_params): """ def _decorator(func): # pylint: disable=missing-docstring @wraps(func) - def _wrapped(*args, **_kwargs): # pylint: disable=missing-docstring + def _wrapped(*args, **_kwargs): request = args[0] missing_params = set(required_params) - set(request.POST.keys()) if len(missing_params) > 0: diff --git a/openedx/core/djangoapps/user_api/management/tests/test_email_opt_in_list.py b/openedx/core/djangoapps/user_api/management/tests/test_email_opt_in_list.py index a367514667..2b6eef912c 100644 --- a/openedx/core/djangoapps/user_api/management/tests/test_email_opt_in_list.py +++ b/openedx/core/djangoapps/user_api/management/tests/test_email_opt_in_list.py @@ -269,7 +269,7 @@ class EmailOptInListTest(ModuleStoreTestCase): def test_file_already_exists(self): temp_file = tempfile.NamedTemporaryFile(delete=True) - def _cleanup(): # pylint: disable=missing-docstring + def _cleanup(): temp_file.close() with self.assertRaisesRegexp(CommandError, "^File already exists"): diff --git a/openedx/core/djangoapps/user_api/preferences/api.py b/openedx/core/djangoapps/user_api/preferences/api.py index ecf2dfff0d..fa348eb38f 100644 --- a/openedx/core/djangoapps/user_api/preferences/api.py +++ b/openedx/core/djangoapps/user_api/preferences/api.py @@ -375,7 +375,6 @@ def validate_user_preference_serializer(serializer, preference_key, preference_v PreferenceValidationError: the supplied key and/or value for a user preference are invalid. """ if preference_value is None or unicode(preference_value).strip() == '': - # pylint: disable=translation-of-non-string format_string = ugettext_noop(u"Preference '{preference_key}' cannot be set to an empty value.") raise PreferenceValidationError({ preference_key: { diff --git a/openedx/core/djangoapps/user_api/tests/test_helpers.py b/openedx/core/djangoapps/user_api/tests/test_helpers.py index ac6c11f4e2..a8a46303da 100644 --- a/openedx/core/djangoapps/user_api/tests/test_helpers.py +++ b/openedx/core/djangoapps/user_api/tests/test_helpers.py @@ -268,8 +268,8 @@ class StudentViewShimTest(TestCase): response = view(HttpRequest()) self.assertEqual(response.status_code, 403) - def _shimmed_view(self, response, check_logged_in=False): # pylint: disable=missing-docstring - def stub_view(request): # pylint: disable=missing-docstring + def _shimmed_view(self, response, check_logged_in=False): + def stub_view(request): self.captured_request = request return response return shim_student_view(stub_view, check_logged_in=check_logged_in) diff --git a/openedx/core/djangoapps/user_api/tests/test_middleware.py b/openedx/core/djangoapps/user_api/tests/test_middleware.py index 98d4c46d94..bb1e79eb02 100644 --- a/openedx/core/djangoapps/user_api/tests/test_middleware.py +++ b/openedx/core/djangoapps/user_api/tests/test_middleware.py @@ -45,7 +45,7 @@ class TagsMiddlewareTest(TestCase): def assertContextSetTo(self, context): """Asserts UserTagsEventContextMiddleware.CONTEXT_NAME matches ``context``""" - self.tracker.get_tracker.return_value.enter_context.assert_called_with( # pylint: disable=maybe-no-member + self.tracker.get_tracker.return_value.enter_context.assert_called_with( UserTagsEventContextMiddleware.CONTEXT_NAME, context ) @@ -109,7 +109,7 @@ class TagsMiddlewareTest(TestCase): self.assertContextSetTo({'course_id': self.course_id, 'course_user_tags': {}}) def test_remove_context(self): - get_tracker = self.tracker.get_tracker # pylint: disable=maybe-no-member + get_tracker = self.tracker.get_tracker exit_context = get_tracker.return_value.exit_context # The middleware should clean up the context when the request is done diff --git a/openedx/core/djangoapps/user_api/tests/test_views.py b/openedx/core/djangoapps/user_api/tests/test_views.py index d756eaa7f2..9f48b0a6d3 100644 --- a/openedx/core/djangoapps/user_api/tests/test_views.py +++ b/openedx/core/djangoapps/user_api/tests/test_views.py @@ -1805,7 +1805,7 @@ class RegistrationViewTest(ThirdPartyAuthTestMixin, UserAPITestCase): "type": "checkbox", "required": True, "errorMessages": { - "required": u"You must agree to the {platform_name} Terms of Service".format( # pylint: disable=line-too-long + "required": u"You must agree to the {platform_name} Terms of Service".format( platform_name=settings.PLATFORM_NAME ) } diff --git a/openedx/core/djangoapps/util/apps.py b/openedx/core/djangoapps/util/apps.py index 852f4dbd09..d3e5b02ba4 100644 --- a/openedx/core/djangoapps/util/apps.py +++ b/openedx/core/djangoapps/util/apps.py @@ -17,5 +17,4 @@ class UtilConfig(AppConfig): """ Registers signal handlers at startup. """ - # pylint: disable=unused-import - import openedx.core.djangoapps.util.signals + import openedx.core.djangoapps.util.signals # pylint: disable=unused-variable diff --git a/openedx/core/djangoapps/verified_track_content/forms.py b/openedx/core/djangoapps/verified_track_content/forms.py index bd82973900..7114666b33 100644 --- a/openedx/core/djangoapps/verified_track_content/forms.py +++ b/openedx/core/djangoapps/verified_track_content/forms.py @@ -21,7 +21,7 @@ class VerifiedTrackCourseForm(forms.ModelForm): error message instead. """ - class Meta(object): # pylint:disable=missing-docstring + class Meta(object): model = VerifiedTrackCohortedCourse fields = '__all__' diff --git a/openedx/core/djangoapps/verified_track_content/tests/test_models.py b/openedx/core/djangoapps/verified_track_content/tests/test_models.py index 9b03ee12cf..2f02af9f7b 100644 --- a/openedx/core/djangoapps/verified_track_content/tests/test_models.py +++ b/openedx/core/djangoapps/verified_track_content/tests/test_models.py @@ -2,7 +2,6 @@ Tests for Verified Track Cohorting models """ # pylint: disable=attribute-defined-outside-init -# pylint: disable=no-member import ddt import mock diff --git a/openedx/core/djangoapps/waffle_utils/models.py b/openedx/core/djangoapps/waffle_utils/models.py index 670b6ee84f..82a85b5f8d 100644 --- a/openedx/core/djangoapps/waffle_utils/models.py +++ b/openedx/core/djangoapps/waffle_utils/models.py @@ -58,5 +58,4 @@ class WaffleFlagCourseOverrideModel(ConfigurationModel): def __unicode__(self): enabled_label = "Enabled" if self.enabled else "Not Enabled" - # pylint: disable=no-member return u"Course '{}': Persistent Grades {}".format(text_type(self.course_id), enabled_label) diff --git a/openedx/core/djangoapps/xmodule_django/models.py b/openedx/core/djangoapps/xmodule_django/models.py index 54436d39a5..c4ac87b7b6 100644 --- a/openedx/core/djangoapps/xmodule_django/models.py +++ b/openedx/core/djangoapps/xmodule_django/models.py @@ -21,7 +21,7 @@ class NoneToEmptyManager(models.Manager): """ Returns the result of NoneToEmptyQuerySet instead of a regular QuerySet. """ - return NoneToEmptyQuerySet(self.model, using=self._db) # pylint: disable=no-member + return NoneToEmptyQuerySet(self.model, using=self._db) class NoneToEmptyQuerySet(models.query.QuerySet): @@ -34,7 +34,6 @@ class NoneToEmptyQuerySet(models.query.QuerySet): empty value. """ def _filter_or_exclude(self, *args, **kwargs): - # pylint: disable=protected-access for field_object in self.model._meta.get_fields(): direct = not field_object.auto_created or field_object.concrete if direct and hasattr(field_object, 'Empty'): diff --git a/openedx/core/djangoapps/zendesk_proxy/v0/views.py b/openedx/core/djangoapps/zendesk_proxy/v0/views.py index d258a9be9e..0c38fa34af 100644 --- a/openedx/core/djangoapps/zendesk_proxy/v0/views.py +++ b/openedx/core/djangoapps/zendesk_proxy/v0/views.py @@ -20,7 +20,7 @@ class ZendeskProxyThrottle(SimpleRateThrottle): self.rate = '{}/hour'.format(ZENDESK_REQUESTS_PER_HOUR) super(ZendeskProxyThrottle, self).__init__() - def get_cache_key(self, request, view): # pylint: disable=unused-argument + def get_cache_key(self, request, view): """ By providing a static string here, we are limiting *all* users to the same combined limit. """ diff --git a/scripts/thresholds.sh b/scripts/thresholds.sh index d880910dde..735f126af9 100755 --- a/scripts/thresholds.sh +++ b/scripts/thresholds.sh @@ -2,6 +2,6 @@ set -e export LOWER_PYLINT_THRESHOLD=1000 -export UPPER_PYLINT_THRESHOLD=2840 +export UPPER_PYLINT_THRESHOLD=2760 export ESLINT_THRESHOLD=5590 export STYLELINT_THRESHOLD=973