From 9aa1f2b73f001b40584fb3621cc7ed35eac0635d Mon Sep 17 00:00:00 2001 From: Christine Lytwynec Date: Fri, 13 Nov 2015 10:43:18 -0500 Subject: [PATCH] use .jshintignore instead of hardcoded directory list --- .jshintignore | 4 ++-- pavelib/quality.py | 6 ++---- scripts/all-tests.sh | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.jshintignore b/.jshintignore index 91523ae0d2..cd0d011354 100644 --- a/.jshintignore +++ b/.jshintignore @@ -1,2 +1,2 @@ -common/static/js/vendor -lms/static/js/vendor +**/vendor +node_modules diff --git a/pavelib/quality.py b/pavelib/quality.py index 9743a869df..f570d623fd 100644 --- a/pavelib/quality.py +++ b/pavelib/quality.py @@ -272,11 +272,9 @@ def run_jshint(options): jshint_report = jshint_report_dir / "jshint.report" _prepare_report_dir(jshint_report_dir) - jshint_directories = ["common/static/js", "cms/static/js", "lms/static/js"] - sh( - "jshint {list} --config .jshintrc >> {jshint_report}".format( - list=(" ".join(jshint_directories)), jshint_report=jshint_report + "jshint {root} --config .jshintrc >> {jshint_report}".format( + root=Env.REPO_ROOT, jshint_report=jshint_report ), ignore_error=True ) diff --git a/scripts/all-tests.sh b/scripts/all-tests.sh index 7fb6ad6377..4c7d709d9e 100755 --- a/scripts/all-tests.sh +++ b/scripts/all-tests.sh @@ -12,7 +12,7 @@ set -e # Violations thresholds for failing the build export PYLINT_THRESHOLD=5650 -export JSHINT_THRESHOLD=3700 +export JSHINT_THRESHOLD=9390 doCheckVars() { if [ -n "$CIRCLECI" ] ; then