Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove pylint pragmas from "class Meta"

Browse Source 
Also remove useless docstrings where they were added to keep pylint
quiet.
This commit is contained in:
Ned Batchelder
2015-10-21 07:37:00 -04:00
parent 1775076500
commit 322ca34b20
48 changed files with 105 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/djangoapps/config_models/models.py
View File

@@ -67,7 +67,7 @@ class ConfigurationModel(models.Model):
should be cached
"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
abstract = True
ordering = ("-change_date", )

2
common/djangoapps/course_modes/admin.py
View File

@@ -31,7 +31,7 @@ from verify_student import models as verification_models # pylint: disable=impo
class CourseModeForm(forms.ModelForm):
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = CourseMode
COURSE_MODE_SLUG_CHOICES = (

1
common/djangoapps/course_modes/models.py
View File

@@ -110,7 +110,6 @@ class CourseMode(models.Model):
UPSELL_TO_VERIFIED_MODES = [HONOR]
class Meta(object):
""" meta attributes of this model """
unique_together = ('course_id', 'mode_slug', 'currency')
def clean(self):

4
common/djangoapps/django_comment_common/models.py
View File

@@ -57,7 +57,7 @@ class Role(models.Model):
users = models.ManyToManyField(User, related_name="roles")
course_id = CourseKeyField(max_length=255, blank=True, db_index=True)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
# use existing table that was originally created from django_comment_client app
db_table = 'django_comment_client_role'
@@ -99,7 +99,7 @@ class Permission(models.Model):
name = models.CharField(max_length=30, null=False, blank=False, primary_key=True)
roles = models.ManyToManyField(Role, related_name="permissions")
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
# use existing table that was originally created from django_comment_client app
db_table = 'django_comment_client_permission'

4
common/djangoapps/embargo/forms.py
View File

@@ -25,7 +25,7 @@ class RestrictedCourseForm(forms.ModelForm):
error message instead.
"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = RestrictedCourse
def clean_course_key(self):
@@ -58,7 +58,7 @@ class RestrictedCourseForm(forms.ModelForm):
class IPFilterForm(forms.ModelForm):
"""Form validating entry of IP addresses"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = IPFilter
def _is_valid_ip(self, address):

2
common/djangoapps/embargo/models.py
View File

@@ -646,7 +646,7 @@ class CourseAccessRuleHistory(models.Model):
else:
CourseAccessRuleHistory.save_snapshot(restricted_course)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
get_latest_by = 'timestamp'

2
common/djangoapps/enrollment/serializers.py
View File

@@ -76,7 +76,7 @@ class CourseEnrollmentSerializer(serializers.ModelSerializer):
"""Retrieves the username from the associated model."""
return model.username
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = CourseEnrollment
fields = ('created', 'mode', 'is_active', 'course_details', 'user')
lookup_field = 'username'

3
common/djangoapps/external_auth/models.py
View File

@@ -14,8 +14,9 @@ from django.contrib.auth.models import User
class ExternalAuthMap(models.Model):
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
unique_together = (('external_id', 'external_domain'), )
external_id = models.CharField(max_length=255, db_index=True)
external_domain = models.CharField(max_length=255, db_index=True)
external_credentials = models.TextField(blank=True) # JSON dictionary

8
common/djangoapps/student/admin.py
View File

@@ -17,7 +17,7 @@ from student.roles import REGISTERED_ACCESS_ROLES
class CourseAccessRoleForm(forms.ModelForm):
"""Form for adding new Course Access Roles view the Django Admin Panel."""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = CourseAccessRole
email = forms.EmailField(required=True)
@@ -125,7 +125,7 @@ class CourseAccessRoleAdmin(admin.ModelAdmin):
class LinkedInAddToProfileConfigurationAdmin(admin.ModelAdmin):
"""Admin interface for the LinkedIn Add to Profile configuration. """
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = LinkedInAddToProfileConfiguration
# Exclude deprecated fields
@@ -144,7 +144,7 @@ class CourseEnrollmentAdmin(admin.ModelAdmin):
return self.readonly_fields + ('course_id', 'mode', 'user',)
return self.readonly_fields
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = CourseEnrollment
@@ -159,7 +159,7 @@ class UserProfileAdmin(admin.ModelAdmin):
return self.readonly_fields + ('user',)
return self.readonly_fields
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = UserProfile

16
common/djangoapps/student/models.py
View File

@@ -216,7 +216,7 @@ class UserProfile(models.Model):
# cache key format e.g user.<user_id>.profile.country = 'SG'
PROFILE_COUNTRY_CACHE_KEY = u"user.{user_id}.profile.country"
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
db_table = "auth_userprofile"
# CRITICAL TODO/SECURITY
@@ -487,7 +487,8 @@ class Registration(models.Model):
registration profile is created when the user creates an
account, but that account is inactive. Once the user clicks
on the activation key, it becomes active. '''
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
db_table = "auth_registration"
user = models.ForeignKey(User, unique=True)
@@ -903,7 +904,7 @@ class CourseEnrollment(models.Model):
# cache key format e.g enrollment.<username>.<course_key>.mode = 'honor'
COURSE_ENROLLMENT_CACHE_KEY = u"enrollment.{}.{}.mode"
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
unique_together = (('user', 'course_id'),)
ordering = ('user', 'course_id')
@@ -1516,7 +1517,7 @@ class CourseEnrollmentAllowed(models.Model):
created = models.DateTimeField(auto_now_add=True, null=True, db_index=True)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
unique_together = (('email', 'course_id'),)
def __unicode__(self):
@@ -1553,7 +1554,7 @@ class CourseAccessRole(models.Model):
course_id = CourseKeyField(max_length=255, db_index=True, blank=True)
role = models.CharField(max_length=64, db_index=True)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
unique_together = ('user', 'org', 'course_id', 'role')
@property
@@ -1882,9 +1883,6 @@ class EntranceExamConfiguration(models.Model):
skip_entrance_exam = models.BooleanField(default=True)
class Meta(object):
"""
Meta class to make user and course_id unique in the table
"""
unique_together = (('user', 'course_id'), )
def __unicode__(self):
@@ -1944,7 +1942,7 @@ class LanguageProficiency(models.Model):
/edx-platform/openedx/core/djangoapps/user_api/accounts/views.py or its associated api method
(update_account_settings) so that the events are emitted.
"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
unique_together = (('code', 'user_profile'),)
user_profile = models.ForeignKey(UserProfile, db_index=True, related_name='language_proficiencies')

12
common/djangoapps/third_party_auth/models.py
View File

@@ -104,7 +104,7 @@ class ProviderConfig(ConfigurationModel):
# "enabled" field is inherited from ConfigurationModel
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
abstract = True
@property
@@ -203,7 +203,7 @@ class OAuth2ProviderConfig(ProviderConfig):
)
other_settings = models.TextField(blank=True, help_text="Optional JSON object with advanced settings, if any.")
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
verbose_name = "Provider Configuration (OAuth)"
verbose_name_plural = verbose_name
@@ -282,7 +282,7 @@ class SAMLProviderConfig(ProviderConfig):
super(SAMLProviderConfig, self).clean()
self.other_settings = clean_json(self.other_settings, dict)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
verbose_name = "Provider Configuration (SAML IdP)"
verbose_name_plural = "Provider Configuration (SAML IdPs)"
@@ -373,7 +373,7 @@ class SAMLConfiguration(ConfigurationModel):
),
)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
verbose_name = "SAML Configuration"
verbose_name_plural = verbose_name
@@ -439,7 +439,7 @@ class SAMLProviderData(models.Model):
sso_url = models.URLField(verbose_name="SSO URL")
public_key = models.TextField()
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
verbose_name = "SAML Provider Data"
verbose_name_plural = verbose_name
ordering = ('-fetched_at', )
@@ -551,6 +551,6 @@ class LTIProviderConfig(ProviderConfig):
return self.lti_consumer_secret
return getattr(settings, 'SOCIAL_AUTH_LTI_CONSUMER_SECRETS', {}).get(self.lti_consumer_key, '')
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
verbose_name = "Provider Configuration (LTI)"
verbose_name_plural = verbose_name

2
common/djangoapps/track/backends/django.py
View File

@@ -46,7 +46,7 @@ class TrackingLog(models.Model):
time = models.DateTimeField('event time')
host = models.CharField(max_length=64, blank=True)
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
app_label = 'track'
db_table = 'track_trackinglog'

2
common/lib/xmodule/xmodule/modulestore/tests/factories.py
View File

@@ -74,7 +74,7 @@ class XModuleFactory(Factory):
# We have to give a model for Factory.
# However, the class that we create is actually determined by the category
# specified in the factory
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = Dummy
@lazy_attribute

4
common/lib/xmodule/xmodule/tests/test_xblock_wrappers.py
View File

@@ -104,7 +104,7 @@ class ModuleSystemFactory(Factory):
performed by :func:`xmodule.tests.get_test_system`, so
arguments for that function are valid factory attributes.
"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = ModuleSystem
@classmethod
@@ -120,7 +120,7 @@ class DescriptorSystemFactory(Factory):
performed by :func:`xmodule.tests.get_test_descriptor_system`, so
arguments for that function are valid factory attributes.
"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = DescriptorSystem
@classmethod

2
common/lib/xmodule/xmodule/tests/xml/factories.py
View File

@@ -64,7 +64,7 @@ class XmlImportFactory(Factory):
Factory for generating XmlImportData's, which can hold all the data needed
to run an XModule XML import
"""
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = XmlImportData
filesystem = MemoryFS()

6
common/test/acceptance/fixtures/discussion.py
View File

@@ -12,8 +12,9 @@ from . import COMMENTS_STUB_URL
class ContentFactory(factory.Factory):
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = dict
id = None
user_id = "1234"
username = "dummy-username"
@@ -64,8 +65,9 @@ class Response(Comment):
class SearchResult(factory.Factory):
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = dict
discussion_data = []
annotated_content_info = {}
num_pages = 1

6
common/test/acceptance/fixtures/edxnotes.py
View File

@@ -10,8 +10,9 @@ from . import EDXNOTES_STUB_URL
class Range(factory.Factory):
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = dict
start = "/div[1]/p[1]"
end = "/div[1]/p[1]"
startOffset = 0
@@ -19,8 +20,9 @@ class Range(factory.Factory):
class Note(factory.Factory):
class Meta(object): # pylint: disable=missing-docstring
class Meta(object):
model = dict
user = "dummy-user"
usage_id = "dummy-usage-id"
course_id = "dummy-course-id"