diff --git a/common/djangoapps/student/tests/factories.py b/common/djangoapps/student/tests/factories.py index b2da6a91bc..4c9130f9b1 100644 --- a/common/djangoapps/student/tests/factories.py +++ b/common/djangoapps/student/tests/factories.py @@ -29,6 +29,7 @@ from common.djangoapps.student.roles import GlobalStaff from common.djangoapps.student.roles import CourseBetaTesterRole from common.djangoapps.student.roles import CourseInstructorRole from common.djangoapps.student.roles import CourseStaffRole +from common.djangoapps.student.roles import OrgStaffRole # Factories are self documenting @@ -272,6 +273,20 @@ class InstructorFactory(UserFactory): CourseInstructorRole(extracted).add_users(self) +class OrgStaffFactory(UserFactory): + """ + Given a course Location, returns a User object with org-staff + permissions for `course`. + """ + last_name = 'Org-Staff' + + @factory.post_generation + def course_key(self, _create, extracted, **kwargs): + if extracted is None: + raise ValueError('Must specify a CourseKey for an org-staff user') + OrgStaffRole(extracted.org).add_users(self) + + class StaffFactory(UserFactory): """ Given a course Location, returns a User object with staff diff --git a/lms/djangoapps/courseware/tests/factories.py b/lms/djangoapps/courseware/tests/factories.py index ab71238887..3b54903b82 100644 --- a/lms/djangoapps/courseware/tests/factories.py +++ b/lms/djangoapps/courseware/tests/factories.py @@ -18,7 +18,6 @@ from lms.djangoapps.courseware.models import ( ) from common.djangoapps.student.roles import ( OrgInstructorRole, - OrgStaffRole ) # Imported to re-export from common.djangoapps.student.tests.factories import UserFactory @@ -39,20 +38,6 @@ class UserProfileFactory(StudentUserProfileFactory): # course_key(self, create, extracted, **kwargs) # pylint: disable=unused-argument -class OrgStaffFactory(UserFactory): - """ - Given a course Location, returns a User object with org-staff - permissions for `course`. - """ - last_name = "Org-Staff" - - @factory.post_generation - def course_key(self, create, extracted, **kwargs): - if extracted is None: - raise ValueError("Must specify a CourseKey for an org-staff user") - OrgStaffRole(extracted.org).add_users(self) - - class OrgInstructorFactory(UserFactory): """ Given a course Location, returns a User object with org-instructor diff --git a/lms/djangoapps/courseware/tests/test_view_authentication.py b/lms/djangoapps/courseware/tests/test_view_authentication.py index 3fd16c4fdd..d9af5cf60c 100644 --- a/lms/djangoapps/courseware/tests/test_view_authentication.py +++ b/lms/djangoapps/courseware/tests/test_view_authentication.py @@ -12,11 +12,11 @@ from django.urls import reverse from common.djangoapps.student.tests.factories import BetaTesterFactory from common.djangoapps.student.tests.factories import GlobalStaffFactory from common.djangoapps.student.tests.factories import InstructorFactory +from common.djangoapps.student.tests.factories import OrgStaffFactory from common.djangoapps.student.tests.factories import StaffFactory from lms.djangoapps.courseware.access import has_access from lms.djangoapps.courseware.tests.factories import ( OrgInstructorFactory, - OrgStaffFactory, ) from lms.djangoapps.courseware.tests.helpers import CourseAccessTestMixin, LoginEnrollmentTestCase from openedx.features.enterprise_support.tests.mixins.enterprise import EnterpriseTestConsentRequired diff --git a/openedx/features/content_type_gating/tests/test_access.py b/openedx/features/content_type_gating/tests/test_access.py index 96d69625e7..177899aae7 100644 --- a/openedx/features/content_type_gating/tests/test_access.py +++ b/openedx/features/content_type_gating/tests/test_access.py @@ -19,11 +19,11 @@ from common.djangoapps.course_modes.tests.factories import CourseModeFactory from common.djangoapps.student.tests.factories import BetaTesterFactory from common.djangoapps.student.tests.factories import GlobalStaffFactory from common.djangoapps.student.tests.factories import InstructorFactory +from common.djangoapps.student.tests.factories import OrgStaffFactory from common.djangoapps.student.tests.factories import StaffFactory from lms.djangoapps.courseware.module_render import load_single_xblock from lms.djangoapps.courseware.tests.factories import ( OrgInstructorFactory, - OrgStaffFactory, ) from lms.djangoapps.courseware.tests.helpers import MasqueradeMixin from lms.djangoapps.discussion.django_comment_client.tests.factories import RoleFactory diff --git a/openedx/features/course_duration_limits/tests/test_course_expiration.py b/openedx/features/course_duration_limits/tests/test_course_expiration.py index 4a78d167d0..70c67acbcb 100644 --- a/openedx/features/course_duration_limits/tests/test_course_expiration.py +++ b/openedx/features/course_duration_limits/tests/test_course_expiration.py @@ -17,10 +17,10 @@ from common.djangoapps.student.tests.factories import BetaTesterFactory from common.djangoapps.student.tests.factories import TEST_PASSWORD, CourseEnrollmentFactory, UserFactory from common.djangoapps.student.tests.factories import GlobalStaffFactory from common.djangoapps.student.tests.factories import InstructorFactory +from common.djangoapps.student.tests.factories import OrgStaffFactory from common.djangoapps.student.tests.factories import StaffFactory from lms.djangoapps.courseware.tests.factories import ( OrgInstructorFactory, - OrgStaffFactory, ) from lms.djangoapps.courseware.tests.helpers import MasqueradeMixin from lms.djangoapps.discussion.django_comment_client.tests.factories import RoleFactory diff --git a/openedx/features/course_experience/tests/views/test_course_home.py b/openedx/features/course_experience/tests/views/test_course_home.py index 4d13de92ed..57593d5f5d 100644 --- a/openedx/features/course_experience/tests/views/test_course_home.py +++ b/openedx/features/course_experience/tests/views/test_course_home.py @@ -24,6 +24,7 @@ from common.djangoapps.course_modes.tests.factories import CourseModeFactory from common.djangoapps.student.tests.factories import BetaTesterFactory from common.djangoapps.student.tests.factories import GlobalStaffFactory from common.djangoapps.student.tests.factories import InstructorFactory +from common.djangoapps.student.tests.factories import OrgStaffFactory from common.djangoapps.student.tests.factories import StaffFactory from common.djangoapps.util.date_utils import strftime_localized_html from lms.djangoapps.experiments.models import ExperimentData @@ -32,7 +33,6 @@ from lms.djangoapps.commerce.utils import EcommerceService from lms.djangoapps.course_goals.api import add_course_goal, remove_course_goal from lms.djangoapps.courseware.tests.factories import ( OrgInstructorFactory, - OrgStaffFactory, ) from lms.djangoapps.courseware.tests.helpers import get_expiration_banner_text from lms.djangoapps.courseware.utils import verified_upgrade_deadline_link