From e82735f79d099be8fada04303d1bca8fb17c439a Mon Sep 17 00:00:00 2001 From: Usman Khalid <2200617@gmail.com> Date: Wed, 22 Apr 2015 22:38:52 +0500 Subject: [PATCH 1/2] Change image upload input name and not make duplicate of file in data. TNL-2052 --- lms/static/js/views/fields.js | 2 +- lms/templates/fields/field_image.underscore | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lms/static/js/views/fields.js b/lms/static/js/views/fields.js index b42736e53c..c8c3b317dc 100644 --- a/lms/static/js/views/fields.js +++ b/lms/static/js/views/fields.js @@ -583,6 +583,7 @@ render: function () { this.$el.html(this.template({ id: this.options.valueAttribute, + inputName: (this.options.inputName || 'file'), imageUrl: _.result(this, 'imageUrl'), imageAltText: _.result(this, 'imageAltText'), uploadButtonIcon: _.result(this, 'iconUpload'), @@ -679,7 +680,6 @@ fileSelected: function (e, data) { if (_.isUndefined(data.files[0].size) || this.validateImageSize(data.files[0].size)) { - data.formData = {file: data.files[0]}; this.setCurrentStatus('uploading'); this.setRemoveButtonVisibility('none'); this.showUploadInProgressMessage(); diff --git a/lms/templates/fields/field_image.underscore b/lms/templates/fields/field_image.underscore index 4e5b04fe1b..bf21952ca5 100644 --- a/lms/templates/fields/field_image.underscore +++ b/lms/templates/fields/field_image.underscore @@ -4,7 +4,7 @@ From 4f5a2e1bc857cd86e5029eaccfc405efa149a1f5 Mon Sep 17 00:00:00 2001 From: Andy Armstrong Date: Wed, 22 Apr 2015 15:59:41 -0400 Subject: [PATCH 2/2] Fix default profile images for edx.org TNL-2054 --- lms/envs/aws.py | 2 ++ lms/envs/common.py | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lms/envs/aws.py b/lms/envs/aws.py index f095b52f9f..9d21ce3760 100644 --- a/lms/envs/aws.py +++ b/lms/envs/aws.py @@ -605,3 +605,5 @@ PROFILE_IMAGE_DEFAULT_FILENAME = ENV_TOKENS.get('PROFILE_IMAGE_DEFAULT_FILENAME' PROFILE_IMAGE_SECRET_KEY = AUTH_TOKENS.get('PROFILE_IMAGE_SECRET_KEY', PROFILE_IMAGE_SECRET_KEY) PROFILE_IMAGE_MAX_BYTES = ENV_TOKENS.get('PROFILE_IMAGE_MAX_BYTES', PROFILE_IMAGE_MAX_BYTES) PROFILE_IMAGE_MIN_BYTES = ENV_TOKENS.get('PROFILE_IMAGE_MIN_BYTES', PROFILE_IMAGE_MIN_BYTES) +if FEATURES['IS_EDX_DOMAIN']: + PROFILE_IMAGE_DEFAULT_FILENAME = 'images/edx-theme/default-profile' diff --git a/lms/envs/common.py b/lms/envs/common.py index 7a4129d4ca..ba3a01992b 100644 --- a/lms/envs/common.py +++ b/lms/envs/common.py @@ -2274,9 +2274,7 @@ PROFILE_IMAGE_BACKEND = { 'base_url': os.path.join(MEDIA_URL, 'profile-images/'), }, } -PROFILE_IMAGE_DEFAULT_FILENAME = ( - 'images/edx-theme/default-profile' if FEATURES['IS_EDX_DOMAIN'] else 'images/default-theme/default-profile' -) +PROFILE_IMAGE_DEFAULT_FILENAME = 'images/default-theme/default-profile' PROFILE_IMAGE_DEFAULT_FILE_EXTENSION = 'png' # This secret key is used in generating unguessable URLs to users' # profile images. Once it has been set, changing it will make the