From 2e0b5b24d883573acb2113ca86091b29f535c6d0 Mon Sep 17 00:00:00 2001 From: Will Daly Date: Mon, 13 May 2013 15:21:45 -0400 Subject: [PATCH] Pylint and pep8 fixes --- common/djangoapps/terrain/browser.py | 38 ++++++++++++++++------------ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/common/djangoapps/terrain/browser.py b/common/djangoapps/terrain/browser.py index b52ae2b712..7ae0a7bc46 100644 --- a/common/djangoapps/terrain/browser.py +++ b/common/djangoapps/terrain/browser.py @@ -1,3 +1,11 @@ +""" +Browser set up for acceptance tests. +""" + +#pylint: disable=E1101 +#pylint: disable=W0613 +#pylint: disable=W0611 + from lettuce import before, after, world from splinter.browser import Browser from logging import getLogger @@ -24,42 +32,40 @@ else: import sys sys.modules['django.contrib.staticfiles'] = staticfiles -logger = getLogger(__name__) -logger.info("Loading the lettuce acceptance testing terrain file...") - +LOGGER = getLogger(__name__) +LOGGER.info("Loading the lettuce acceptance testing terrain file...") @before.harvest def initial_setup(server): - ''' - Launch the browser once before executing the tests - ''' + """ + Launch the browser once before executing the tests. + """ browser_driver = getattr(settings, 'LETTUCE_BROWSER', 'chrome') world.browser = Browser(browser_driver) @before.each_scenario def reset_data(scenario): - ''' + """ Clean out the django test database defined in the envs/acceptance.py file: mitx_all/db/test_mitx.db - ''' - logger.debug("Flushing the test database...") + """ + LOGGER.debug("Flushing the test database...") call_command('flush', interactive=False) @after.each_scenario def screenshot_on_error(scenario): - ''' - Save a screenshot to help with debugging - ''' + """ + Save a screenshot to help with debugging. + """ if scenario.failed: world.browser.driver.save_screenshot('/tmp/last_failed_scenario.png') @after.all def teardown_browser(total): - ''' - Quit the browser after executing the tests - ''' + """ + Quit the browser after executing the tests. + """ world.browser.quit() - pass