Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #22643 from edx/feanil/2to3_asserts

Browse Source 
Run `2to3 -f asserts . -w` on edx-platform.
This commit is contained in:
Feanil Patel
2019-12-30 12:13:42 -05:00
committed by GitHub
parent 61e1eda20d 39d3a7ca17
commit 2df8b8226b
214 changed files with 1459 additions and 1464 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
lms/djangoapps/instructor_task/tests/test_views.py
View File

@@ -38,7 +38,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
request.GET = request.POST = {'task_id': task_id}
response = instructor_task_status(request)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output['task_id'], task_id)
self.assertEqual(output['task_id'], task_id)
def test_missing_instructor_task_status(self):
task_id = "missing_id"
@@ -46,7 +46,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
request.GET = request.POST = {'task_id': task_id}
response = instructor_task_status(request)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output, {})
self.assertEqual(output, {})
def test_instructor_task_status_list(self):
# Fetch status for existing tasks by arg list, as if called from ajax.
@@ -59,9 +59,9 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
request.GET = request.POST = task_ids_query_dict
response = instructor_task_status(request)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(len(output), len(task_ids))
self.assertEqual(len(output), len(task_ids))
for task_id in task_ids:
self.assertEquals(output[task_id]['task_id'], task_id)
self.assertEqual(output[task_id]['task_id'], task_id)
def test_get_status_from_failure(self):
# get status for a task that has already failed
@@ -69,16 +69,16 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
task_id = instructor_task.task_id
response = self._get_instructor_task_status(task_id)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output['message'], TEST_FAILURE_MESSAGE)
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_id'], task_id)
self.assertEquals(output['task_state'], FAILURE)
self.assertEqual(output['message'], TEST_FAILURE_MESSAGE)
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_id'], task_id)
self.assertEqual(output['task_state'], FAILURE)
self.assertFalse(output['in_progress'])
expected_progress = {
'exception': TEST_FAILURE_EXCEPTION,
'message': TEST_FAILURE_MESSAGE,
}
self.assertEquals(output['task_progress'], expected_progress)
self.assertEqual(output['task_progress'], expected_progress)
def test_get_status_from_success(self):
# get status for a task that has already succeeded
@@ -86,10 +86,10 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
task_id = instructor_task.task_id
response = self._get_instructor_task_status(task_id)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output['message'], "Problem rescored for 2 of 3 students (out of 5)")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_id'], task_id)
self.assertEquals(output['task_state'], SUCCESS)
self.assertEqual(output['message'], "Problem rescored for 2 of 3 students (out of 5)")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_id'], task_id)
self.assertEqual(output['task_state'], SUCCESS)
self.assertFalse(output['in_progress'])
expected_progress = {
'attempted': 3,
@@ -97,7 +97,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
'total': 5,
'action_name': 'rescored',
}
self.assertEquals(output['task_progress'], expected_progress)
self.assertEqual(output['task_progress'], expected_progress)
def test_get_status_from_legacy_success(self):
# get status for a task that had already succeeded, back at a time
@@ -112,12 +112,12 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
task_id = instructor_task.task_id
response = self._get_instructor_task_status(task_id)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output['message'], "Problem rescored for 2 of 3 students (out of 5)")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_id'], task_id)
self.assertEquals(output['task_state'], SUCCESS)
self.assertEqual(output['message'], "Problem rescored for 2 of 3 students (out of 5)")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_id'], task_id)
self.assertEqual(output['task_state'], SUCCESS)
self.assertFalse(output['in_progress'])
self.assertEquals(output['task_progress'], legacy_progress)
self.assertEqual(output['task_progress'], legacy_progress)
def _create_email_subtask_entry(self, total=5, attempted=3, succeeded=2, skipped=0, task_state=PROGRESS):
"""Create an InstructorTask with subtask defined and email argument."""
@@ -140,10 +140,10 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
task_id = instructor_task.task_id
response = self._get_instructor_task_status(task_id)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output['message'], "Progress: emailed 2 of 3 so far (skipping 1) (out of 5)")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_id'], task_id)
self.assertEquals(output['task_state'], PROGRESS)
self.assertEqual(output['message'], "Progress: emailed 2 of 3 so far (skipping 1) (out of 5)")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_id'], task_id)
self.assertEqual(output['task_state'], PROGRESS)
self.assertTrue(output['in_progress'])
expected_progress = {
'attempted': 3,
@@ -152,7 +152,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
'total': 5,
'action_name': 'emailed',
}
self.assertEquals(output['task_progress'], expected_progress)
self.assertEqual(output['task_progress'], expected_progress)
def _test_get_status_from_result(self, task_id, mock_result=None):
"""
@@ -162,7 +162,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
mock_result_ctor.return_value = mock_result
response = self._get_instructor_task_status(task_id)
output = json.loads(response.content.decode('utf-8'))
self.assertEquals(output['task_id'], task_id)
self.assertEqual(output['task_id'], task_id)
return output
def test_get_status_to_pending(self):
@@ -175,7 +175,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
output = self._test_get_status_from_result(task_id, mock_result)
for key in ['message', 'succeeded', 'task_progress']:
self.assertNotIn(key, output)
self.assertEquals(output['task_state'], 'PENDING')
self.assertEqual(output['task_state'], 'PENDING')
self.assertTrue(output['in_progress'])
def test_update_progress_to_progress(self):
@@ -192,11 +192,11 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
'action_name': 'rescored',
}
output = self._test_get_status_from_result(task_id, mock_result)
self.assertEquals(output['message'], "Progress: rescored 4 of 5 so far (out of 10)")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_state'], PROGRESS)
self.assertEqual(output['message'], "Progress: rescored 4 of 5 so far (out of 10)")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_state'], PROGRESS)
self.assertTrue(output['in_progress'])
self.assertEquals(output['task_progress'], mock_result.result)
self.assertEqual(output['task_progress'], mock_result.result)
def test_update_progress_to_failure(self):
# view task entry for task in progress that later fails
@@ -208,16 +208,16 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
mock_result.result = NotImplementedError("This task later failed.")
mock_result.traceback = "random traceback"
output = self._test_get_status_from_result(task_id, mock_result)
self.assertEquals(output['message'], "This task later failed.")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_state'], FAILURE)
self.assertEqual(output['message'], "This task later failed.")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_state'], FAILURE)
self.assertFalse(output['in_progress'])
expected_progress = {
'exception': 'NotImplementedError',
'message': "This task later failed.",
'traceback': "random traceback",
}
self.assertEquals(output['task_progress'], expected_progress)
self.assertEqual(output['task_progress'], expected_progress)
def test_update_progress_to_revoked(self):
# view task entry for task in progress that later fails
@@ -227,12 +227,12 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
mock_result.task_id = task_id
mock_result.state = REVOKED
output = self._test_get_status_from_result(task_id, mock_result)
self.assertEquals(output['message'], "Task revoked before running")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_state'], REVOKED)
self.assertEqual(output['message'], "Task revoked before running")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_state'], REVOKED)
self.assertFalse(output['in_progress'])
expected_progress = {'message': "Task revoked before running"}
self.assertEquals(output['task_progress'], expected_progress)
self.assertEqual(output['task_progress'], expected_progress)
def _get_output_for_task_success(self, attempted, succeeded, total, student=None):
"""returns the task_id and the result returned by instructor_task_status()."""
@@ -264,9 +264,9 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
def test_update_progress_to_success(self):
output = self._get_output_for_task_success(10, 8, 10)
self.assertEquals(output['message'], "Problem rescored for 8 of 10 students")
self.assertEquals(output['succeeded'], False)
self.assertEquals(output['task_state'], SUCCESS)
self.assertEqual(output['message'], "Problem rescored for 8 of 10 students")
self.assertEqual(output['succeeded'], False)
self.assertEqual(output['task_state'], SUCCESS)
self.assertFalse(output['in_progress'])
expected_progress = {
'attempted': 10,
@@ -274,7 +274,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
'total': 10,
'action_name': 'rescored',
}
self.assertEquals(output['task_progress'], expected_progress)
self.assertEqual(output['task_progress'], expected_progress)
def test_success_messages(self):
output = self._get_output_for_task_success(0, 0, 10)
@@ -355,7 +355,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
instructor_task = self._create_entry()
succeeded, message = get_task_completion_info(instructor_task)
self.assertFalse(succeeded)
self.assertEquals(message, "No status information available")
self.assertEqual(message, "No status information available")
def test_get_info_for_missing_output(self):
# check for missing task_output
@@ -363,7 +363,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
instructor_task.task_output = None
succeeded, message = get_task_completion_info(instructor_task)
self.assertFalse(succeeded)
self.assertEquals(message, "No status information available")
self.assertEqual(message, "No status information available")
def test_get_info_for_broken_output(self):
# check for non-JSON task_output
@@ -371,7 +371,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
instructor_task.task_output = u"{ bad"
succeeded, message = get_task_completion_info(instructor_task)
self.assertFalse(succeeded)
self.assertEquals(message, "No parsable status information available")
self.assertEqual(message, "No parsable status information available")
def test_get_info_for_empty_output(self):
# check for JSON task_output with missing keys
@@ -379,7 +379,7 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
instructor_task.task_output = "{}"
succeeded, message = get_task_completion_info(instructor_task)
self.assertFalse(succeeded)
self.assertEquals(message, "No progress status information available")
self.assertEqual(message, "No progress status information available")
def test_get_info_for_broken_input(self):
# check for non-JSON task_input, but then just ignore it
@@ -387,4 +387,4 @@ class InstructorTaskReportTest(InstructorTaskTestCase):
instructor_task.task_input = u"{ bad"
succeeded, message = get_task_completion_info(instructor_task)
self.assertFalse(succeeded)
self.assertEquals(message, "Status: rescored 2 of 3 (out of 5)")
self.assertEqual(message, "Status: rescored 2 of 3 (out of 5)")