Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "username and email request for lti module"

Browse Source 
This reverts commit 3f159ea52b.
This commit is contained in:
Ned Batchelder
2014-09-16 16:13:41 -04:00
committed by John Eskew
parent d1d3a69e62
commit 2d05ffacdf
4 changed files with 1 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/lib/xmodule/xmodule/css/lti/lti.scss
View File

@@ -32,10 +32,6 @@ div.lti {
}
}
div.ltiTextBox {
width: 280px;
}
form.ltiLaunchForm {
display: none;
}

54
common/lib/xmodule/xmodule/lti_module.py
View File

@@ -191,35 +191,6 @@ class LTIFields(object):
default=False,
scope=Scope.settings
)
"""
Users will be presented with a message indicating that their e-mail/username would be sent to a third
party application. When "Open in new Page" is not selected, the tool automatically appears without any user action.
"""
request_username = Boolean(
display_name=_("Request user's username"),
help=_(
"Requesting user's username will only work if 'Open in a new page' is set to True"
),
default=False,
scope=Scope.settings
)
request_email = Boolean(
display_name=_("Request user's email"),
help=_(
"Requesting user's email will only work if 'Open in a new page' is set to True"
),
default=False,
scope=Scope.settings
)
text_box = String(
display_name=_("LTI Application Information"),
help=_(
"Provide a description of the third party application. If requesting username and/or email, use this text box to inform users "
"that their username and/or email will be forwarded to a third party application."),
default="",
scope=Scope.settings
)
class LTIModule(LTIFields, LTI20ModuleMixin, XModule):
@@ -346,7 +317,6 @@ class LTIModule(LTIFields, LTI20ModuleMixin, XModule):
# parsing custom parameters to dict
custom_parameters = {}
for custom_parameter in self.custom_parameters:
try:
param_name, param_value = [p.strip() for p in custom_parameter.split('=', 1)]
@@ -400,10 +370,6 @@ class LTIModule(LTIFields, LTI20ModuleMixin, XModule):
'weight': self.weight,
'module_score': self.module_score,
'comment': sanitized_comment,
'text_box': self.text_box,
'request_username': self.request_username,
'request_email': self.request_email,
}
def get_html(self):
@@ -550,26 +516,6 @@ class LTIModule(LTIFields, LTI20ModuleMixin, XModule):
u'lis_outcome_service_url': self.get_outcome_service_url()
})
self.user_email = ""
self.user_username = ""
# Username and email can't be sent in studio mode, because the user object is not defined.
# To test functionality test in LMS
if self.runtime.get_real_user is not None:
real_user_object = self.runtime.get_real_user(self.runtime.anonymous_student_id)
self.user_email = real_user_object.email
self.user_username = real_user_object.username
if self.request_username and self.user_username and self.open_in_a_new_page:
body.update({
u'lis_person_sourcedid': self.user_username
})
if self.request_email and self.user_email and self.open_in_a_new_page:
body.update({
u'lis_person_contact_email_primary': self.user_email
})
# Appending custom parameter for signing.
body.update(custom_parameters)