From 2cbba5b4c819b7156448c751cb6cc01936d30650 Mon Sep 17 00:00:00 2001 From: Kira Date: Thu, 21 Apr 2022 16:33:56 -0400 Subject: [PATCH] fix: PR requests --- .../third_party_auth/samlproviderconfig/views.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/common/djangoapps/third_party_auth/samlproviderconfig/views.py b/common/djangoapps/third_party_auth/samlproviderconfig/views.py index 95c8c6b32c..90fca52303 100644 --- a/common/djangoapps/third_party_auth/samlproviderconfig/views.py +++ b/common/djangoapps/third_party_auth/samlproviderconfig/views.py @@ -58,17 +58,8 @@ class SAMLProviderConfigViewSet(PermissionRequiredMixin, SAMLProviderMixin, view EnterpriseCustomerIdentityProvider, enterprise_customer__uuid=self.requested_enterprise_uuid ) - slug_list = [] - config_list = [] - for idp in enterprise_customer_idps: - slug_list.append(convert_saml_slug_provider_id(idp.provider_id)) - - for config in SAMLProviderConfig.objects.current_set(): - slug = convert_saml_slug_provider_id(config.provider_id) - if slug in slug_list: - config_list.append(config) - - return config_list + slug_list = [ idp.provider_id for idp in enterprise_customer_idps ] + return [ config for config in SAMLProviderConfig.objects.current_set() if config.provider_id in slug_list ] @property def requested_enterprise_uuid(self):