From 2c4e97ebfab54bd37eb326d24c98ac3bbfaaa8c9 Mon Sep 17 00:00:00 2001 From: Omar Khan Date: Tue, 9 Feb 2016 15:45:21 +0700 Subject: [PATCH] Don't remove auth_url method --- common/djangoapps/third_party_auth/saml.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/common/djangoapps/third_party_auth/saml.py b/common/djangoapps/third_party_auth/saml.py index 68898434e4..1ea831253e 100644 --- a/common/djangoapps/third_party_auth/saml.py +++ b/common/djangoapps/third_party_auth/saml.py @@ -39,12 +39,11 @@ class SAMLAuthBackend(SAMLAuth): # pylint: disable=abstract-method raise Http404 if SAML is disabled raise AuthMissingParameter if the 'idp' parameter is missing. - - TODO: remove this method once the fix is merged upstream: - https://github.com/omab/python-social-auth/pull/821 """ if not self._config.enabled: raise Http404 + # TODO: remove this check once the fix is merged upstream: + # https://github.com/omab/python-social-auth/pull/821 if 'idp' not in self.strategy.request_data(): raise AuthMissingParameter(self, 'idp') return super(SAMLAuthBackend, self).auth_url()