From 2b2f6d18d64f76313a5d4fa0ae5a835ff56de8a7 Mon Sep 17 00:00:00 2001 From: Eric Fischer Date: Tue, 19 Jan 2016 15:23:48 -0500 Subject: [PATCH] Wait for text to appear Adding a wait statement to allow ajax calls to finish before making assertions about text that has changed. Fixes TNL-3943 flaky test ticket. --- common/test/acceptance/pages/lms/discussion.py | 1 + common/test/acceptance/tests/discussion/test_discussion.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/common/test/acceptance/pages/lms/discussion.py b/common/test/acceptance/pages/lms/discussion.py index a16f33819d..6a8275fb5d 100644 --- a/common/test/acceptance/pages/lms/discussion.py +++ b/common/test/acceptance/pages/lms/discussion.py @@ -277,6 +277,7 @@ class DiscussionThreadPage(PageObject, DiscussionPageMixin): def submit_comment_edit(self, comment_id, new_comment_body): """Click the submit button on the comment editor""" self._find_within("#comment_{} .post-update".format(comment_id)).first.click() + self.wait_for_ajax() EmptyPromise( lambda: ( not self.is_comment_editor_visible(comment_id) and diff --git a/common/test/acceptance/tests/discussion/test_discussion.py b/common/test/acceptance/tests/discussion/test_discussion.py index 379ef9d4bb..d96f5d163c 100644 --- a/common/test/acceptance/tests/discussion/test_discussion.py +++ b/common/test/acceptance/tests/discussion/test_discussion.py @@ -547,7 +547,6 @@ class DiscussionCommentEditTest(BaseDiscussionTestCase): self.assertFalse(page.is_comment_editable("comment_other_author")) self.edit_comment(page, "comment_self_author") - @skip # TODO: See TNL-3943 def test_edit_comment_as_moderator(self): self.setup_user(roles=["Moderator"]) self.setup_view()