From d6f719a9703b48423c15002b561801c462cef823 Mon Sep 17 00:00:00 2001 From: Rick Reilly Date: Wed, 23 Jan 2019 16:10:03 -0500 Subject: [PATCH] Remove 'is_graded' prop from the gradebook api reponse --- lms/djangoapps/grades/api/serializers.py | 1 - lms/djangoapps/grades/api/v1/gradebook_views.py | 7 ------- lms/djangoapps/grades/api/v1/tests/test_gradebook_views.py | 4 ---- 3 files changed, 12 deletions(-) diff --git a/lms/djangoapps/grades/api/serializers.py b/lms/djangoapps/grades/api/serializers.py index b17f9a047f..a86cf1b43b 100644 --- a/lms/djangoapps/grades/api/serializers.py +++ b/lms/djangoapps/grades/api/serializers.py @@ -36,7 +36,6 @@ class SectionBreakdownSerializer(serializers.Serializer): """ attempted = serializers.BooleanField() category = serializers.CharField() - is_graded = serializers.BooleanField() label = serializers.CharField() module_id = serializers.CharField() percent = serializers.FloatField() diff --git a/lms/djangoapps/grades/api/v1/gradebook_views.py b/lms/djangoapps/grades/api/v1/gradebook_views.py index 444e6d4556..0ea068e025 100644 --- a/lms/djangoapps/grades/api/v1/gradebook_views.py +++ b/lms/djangoapps/grades/api/v1/gradebook_views.py @@ -364,14 +364,9 @@ class GradebookView(GradeViewMixin, PaginatedAPIView): enabled for this course. **Example GET Response** { - "course_id": "course-v1:edX+DemoX+Demo_Course", - "email": "staff@example.com", "user_id": 9, "username": "staff", - "full_name": "", - "passed": false, "percent": 0.36, - "progress_page_url": "/courses/course-v1:edX+DemoX+Demo_Course/progress/9/", "section_breakdown": [ { "are_grades_published": true, @@ -381,7 +376,6 @@ class GradebookView(GradeViewMixin, PaginatedAPIView): "comment": "", "detail": "", "displayed_value": "0.00", - "is_graded": false, "grade_description": "(0.00/0.00)", "is_ag": false, "is_average": false, @@ -451,7 +445,6 @@ class GradebookView(GradeViewMixin, PaginatedAPIView): breakdown.append({ 'attempted': attempted, 'category': subsection_grade.format, - 'is_graded': subsection_grade.graded, 'label': short_label, 'module_id': text_type(subsection_grade.location), 'percent': subsection_grade.percent_graded, diff --git a/lms/djangoapps/grades/api/v1/tests/test_gradebook_views.py b/lms/djangoapps/grades/api/v1/tests/test_gradebook_views.py index cd416bab5c..cd853aa086 100644 --- a/lms/djangoapps/grades/api/v1/tests/test_gradebook_views.py +++ b/lms/djangoapps/grades/api/v1/tests/test_gradebook_views.py @@ -411,7 +411,6 @@ class GradebookViewTest(GradebookViewTestBase): OrderedDict([ ('attempted', True), ('category', 'Homework'), - ('is_graded', True), ('label', 'HW 01'), ('module_id', text_type(self.subsections[self.chapter_1.location][0].location)), ('percent', 0.5), @@ -422,7 +421,6 @@ class GradebookViewTest(GradebookViewTestBase): OrderedDict([ ('attempted', True), ('category', 'Lab'), - ('is_graded', True), ('label', 'Lab 01'), ('module_id', text_type(self.subsections[self.chapter_1.location][1].location)), ('percent', 0.5), @@ -433,7 +431,6 @@ class GradebookViewTest(GradebookViewTestBase): OrderedDict([ ('attempted', True), ('category', 'Homework'), - ('is_graded', True), ('label', 'HW 02'), ('module_id', text_type(self.subsections[self.chapter_2.location][0].location)), ('percent', 0.5), @@ -444,7 +441,6 @@ class GradebookViewTest(GradebookViewTestBase): OrderedDict([ ('attempted', True), ('category', 'Lab'), - ('is_graded', True), ('label', 'Lab 02'), ('module_id', text_type(self.subsections[self.chapter_2.location][1].location)), ('percent', 0.5),