From 294e24dd8fc4ed7c088ec94be1156a582204ecc6 Mon Sep 17 00:00:00 2001 From: David Baumgold Date: Thu, 16 Apr 2015 10:07:40 -0400 Subject: [PATCH] Strict comparison between expected_fields and displayed_fields --- .../acceptance/tests/studio/test_studio_settings.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/common/test/acceptance/tests/studio/test_studio_settings.py b/common/test/acceptance/tests/studio/test_studio_settings.py index 6df42e9eaa..285da25338 100644 --- a/common/test/acceptance/tests/studio/test_studio_settings.py +++ b/common/test/acceptance/tests/studio/test_studio_settings.py @@ -397,17 +397,7 @@ class AdvancedSettingsValidationTest(StudioCourseTest): When I view the Advanced Settings screen for the course The total number of fields displayed matches the number I expect And the actual fields displayed match the fields I expect to see - - Note that this test will NOT fail if fields that we expect to see are - not displayed, only if fields show up that we did not expect to see. """ expected_fields = self.advanced_settings.expected_settings_names displayed_fields = self.advanced_settings.displayed_settings_names - unexpectedly_displayed = set(displayed_fields) - set(expected_fields) - self.assertEquals( - len(unexpectedly_displayed), - 0, - "The following fields were unexpectedly displayed: {fields}".format( - fields=", ".join(unexpectedly_displayed) - ) - ) + self.assertEquals(set(displayed_fields), set(expected_fields))