diff --git a/lms/djangoapps/instructor/tests/test_services.py b/lms/djangoapps/instructor/tests/test_services.py index 053e8e07b6..84856eac9f 100644 --- a/lms/djangoapps/instructor/tests/test_services.py +++ b/lms/djangoapps/instructor/tests/test_services.py @@ -148,21 +148,39 @@ class InstructorServiceTests(SharedModuleStoreTestCase): requester_name = "edx-proctoring" email = "edx-proctoring@edx.org" subject = u"Proctored Exam Review: {review_status}".format(review_status="Suspicious") + body = "A proctored exam attempt for {exam_name} in {course_name} by username: {student_username} was " \ "reviewed as {review_status} by the proctored exam review provider.\n" \ - "Review link: not available" - body = body.format( - exam_name="test_exam", course_name=self.course.display_name, student_username="test_student", - review_status="Suspicious" - ) + "Review link: {url}" + args = { + 'exam_name': 'test_exam', + 'student_username': 'test_student', + 'url': 'not available', + 'course_name': self.course.display_name, + 'review_status': 'Suspicious', + } + expected_body = body.format(**args) tags = ["proctoring"] with mock.patch("lms.djangoapps.instructor.services.create_zendesk_ticket") as mock_create_zendesk_ticket: self.service.send_support_notification( course_id=unicode(self.course.id), - exam_name="test_exam", - student_username="test_student", - review_status="Suspicious" + exam_name=args['exam_name'], + student_username=args["student_username"], + review_status="Suspicious", + review_url=None, ) - mock_create_zendesk_ticket.assert_called_with(requester_name, email, subject, body, tags) + mock_create_zendesk_ticket.assert_called_with(requester_name, email, subject, expected_body, tags) + # Now check sending a notification with a review link + args['url'] = 'http://review/url' + with mock.patch("lms.djangoapps.instructor.services.create_zendesk_ticket") as mock_create_zendesk_ticket: + self.service.send_support_notification( + course_id=unicode(self.course.id), + exam_name=args['exam_name'], + student_username=args["student_username"], + review_status="Suspicious", + review_url=args['url'], + ) + expected_body = body.format(**args) + mock_create_zendesk_ticket.assert_called_with(requester_name, email, subject, expected_body, tags)