refactor: Misc. clean up from dashboard investigation
There are some refactors to use an existing variable and also some removals for code paths that would never execute
This commit is contained in:
@@ -21,11 +21,6 @@ from openedx.core.djangolib.markup import HTML, Text
|
||||
from common.djangoapps.student.models import CourseEnrollment
|
||||
%>
|
||||
|
||||
<%
|
||||
cert_name_short = settings.CERT_NAME_SHORT
|
||||
cert_name_long = settings.CERT_NAME_LONG
|
||||
%>
|
||||
|
||||
|
||||
<%block name="pagetitle">${_("Dashboard")}</%block>
|
||||
<%block name="bodyclass">view-dashboard is-authenticated</%block>
|
||||
@@ -113,12 +108,6 @@ from common.djangoapps.student.models import CourseEnrollment
|
||||
|
||||
<div class="dashboard-notifications" tabindex="-1">
|
||||
|
||||
%if banner_account_activation_message:
|
||||
<div class="dashboard-banner">
|
||||
${banner_account_activation_message | n, decode.utf8}
|
||||
</div>
|
||||
%endif
|
||||
|
||||
%if enrollment_message:
|
||||
<div class="dashboard-banner">
|
||||
${enrollment_message | n, decode.utf8}
|
||||
|
||||
@@ -33,9 +33,6 @@ from lms.djangoapps.experiments.utils import UPSELL_TRACKING_FLAG
|
||||
|
||||
<%
|
||||
reverify_link = IDVerificationService.get_verify_location()
|
||||
cert_name_short = course_overview.cert_name_short
|
||||
if cert_name_short == "":
|
||||
cert_name_short = settings.CERT_NAME_SHORT
|
||||
|
||||
cert_name_long = course_overview.cert_name_long
|
||||
if cert_name_long == "":
|
||||
@@ -60,8 +57,6 @@ from lms.djangoapps.experiments.utils import UPSELL_TRACKING_FLAG
|
||||
verification_status.get('status'),
|
||||
course_overview.id
|
||||
)
|
||||
%>
|
||||
<%
|
||||
mode_class = course_verified_certs.get('display_mode', '')
|
||||
if mode_class:
|
||||
mode_class = ' ' + mode_class ;
|
||||
@@ -309,7 +304,7 @@ from lms.djangoapps.experiments.utils import UPSELL_TRACKING_FLAG
|
||||
% endif
|
||||
|
||||
% else:
|
||||
<%include file="_dashboard_course_resume.html" args="resume_button_url=resume_button_url, course_overview=course_overview, enrollment=enrollment, is_unfulfilled_entitlement=is_unfulfilled_entitlement, course_target=course_target, related_programs=related_programs"/>
|
||||
<%include file="_dashboard_course_resume.html" args="resume_button_url=resume_button_url, course_overview=course_overview, enrollment=enrollment, is_unfulfilled_entitlement=is_unfulfilled_entitlement, course_target=course_target"/>
|
||||
% endif
|
||||
% endif
|
||||
</div>
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
<%page args="resume_button_url, course_overview, enrollment, is_unfulfilled_entitlement, course_target, related_programs" expression_filter="h"/>
|
||||
<%page args="resume_button_url, course_overview, enrollment, is_unfulfilled_entitlement, course_target" expression_filter="h"/>
|
||||
|
||||
<%!
|
||||
import six
|
||||
|
||||
Reference in New Issue
Block a user