Fix various team accessibility issues.

Authors:
  - Peter Fogg
  - Daniel Friedman

TNL-1953

lms/static/js/components/card/views/card.js

@@ -23,6 +23,8 @@
             'text!templates/components/card/card.underscore'],
         function ($, _, Backbone, cardTemplate) {
             var CardView = Backbone.View.extend({
+                tagName: 'li',
+
                 events: {
                     'click .action' : 'action'
                 },
@@ -82,7 +84,8 @@
                         action_class: this.callIfFunction(this.actionClass),
                         action_url: this.callIfFunction(this.actionUrl),
                         action_content: this.callIfFunction(this.actionContent),
-                        configuration: this.callIfFunction(this.configuration)
+                        configuration: this.callIfFunction(this.configuration),
+                        srInfo: this.srInfo
                     }));
                     var detailsEl = this.$el.find('.card-meta');
                     _.each(this.callIfFunction(this.details), function (detail) {

lms/static/js/components/header/models/header.js

@@ -8,7 +8,8 @@ define(['backbone'], function (Backbone) {
         defaults: {
             'title': '',
             'description': '',
-            'breadcrumbs': null
+            'breadcrumbs': null,
+            'nav_aria_label': ''
         }
     });
 

lms/static/js/components/tabbed/views/tabbed_view.js

@@ -48,7 +48,11 @@
                            }));
                            self.$('.page-content-nav').append(tabEl);
                        });
-                       if(Backbone.history.getHash() === "") {
+                       // Re-display the default (first) tab if the
+                       // current route does not belong to one of the
+                       // tabs.  Otherwise continue displaying the tab
+                       // corresponding to the current URL.
+                       if (!(Backbone.history.getHash() in this.urlMap)) {
                            this.setActiveTab(0);
                        }
                        return this;
@@ -70,7 +74,7 @@
                        view.setElement(this.$('.page-content-main')).render();
                        this.$('.sr-is-focusable.sr-tab').focus();
                        if (this.router) {
-                           this.router.navigate(tab.url, {replace: true, trigger: true});
+                           this.router.navigate(tab.url, {replace: true});
                        }
                    },
 

lms/static/js/spec/components/header/header_spec.js

@@ -13,7 +13,7 @@
 
                    var testBreadcrumbs = function (breadcrumbs) {
                        model.set('breadcrumbs', breadcrumbs);
-                       expect(view.$el.html()).toContain('<nav class="breadcrumbs">');
+                       expect(view.$('nav.breadcrumbs').length).toBe(1);
                        _.each(view.$('.nav-item'), function (el, index) {
                            expect($(el).attr('href')).toEqual(breadcrumbs[index].url);
                            expect($(el).text()).toEqual(breadcrumbs[index].title);

lms/static/js/spec/components/tabbed/tabbed_view_spec.js

@@ -101,7 +101,7 @@
                            view.$('.nav-item[data-index=1]').click();
                            expect(Backbone.history.navigate).toHaveBeenCalledWith(
                                'test 2',
-                               {replace: true, trigger: true}
+                               {replace: true}
                            );
                        });
 

lms/static/sass/shared/_fields.scss

@@ -118,7 +118,7 @@
 
     .u-field-message-help,
     .u-field-message-notification {
-        color: $gray-l1;
+        color: $gray;
     }
 }