From 44468f840e988a001074c6a096d61b560ca1c458 Mon Sep 17 00:00:00 2001 From: Syed Hassan Raza Date: Tue, 20 Jan 2015 19:17:11 +0500 Subject: [PATCH] Hd button on for default high resolutions TNL-1202 --- .../js/spec/video/video_quality_control_spec.js | 13 +++++++++++++ .../js/src/video/05_video_quality_control.js | 3 ++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/common/lib/xmodule/xmodule/js/spec/video/video_quality_control_spec.js b/common/lib/xmodule/xmodule/js/spec/video/video_quality_control_spec.js index d36450c500..1ade3cb9ce 100644 --- a/common/lib/xmodule/xmodule/js/spec/video/video_quality_control_spec.js +++ b/common/lib/xmodule/xmodule/js/spec/video/video_quality_control_spec.js @@ -92,6 +92,19 @@ qualityControl.el.click(); expect(player.setPlaybackQuality).toHaveBeenCalledWith('large'); }); + + it('quality control is active if HD is available', + function () { + player.getAvailableQualityLevels.andReturn( + ['highres', 'hd1080', 'hd720'] + ); + + qualityControl.quality = 'highres'; + + videoPlayer.onPlay(); + expect(qualityControl.el).toHaveClass('active'); + }); + }); describe('constructor, HTML5 mode', function () { diff --git a/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js b/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js index 7678586d4f..03eb4ccad0 100644 --- a/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js +++ b/common/lib/xmodule/xmodule/js/src/video/05_video_quality_control.js @@ -103,6 +103,7 @@ function () { // HD qualities are available, show video quality control. if (this.config.availableHDQualities.length > 0) { this.trigger('videoQualityControl.showQualityControl'); + this.trigger('videoQualityControl.onQualityChange', this.videoQualityControl.quality); } // On initialization, force the video quality to be 'large' instead of // 'default'. Otherwise, the player will sometimes switch to HD @@ -115,7 +116,6 @@ function () { function onQualityChange(value) { var controlStateStr; this.videoQualityControl.quality = value; - if (_.contains(this.config.availableHDQualities, value)) { controlStateStr = gettext('HD on'); this.videoQualityControl.el @@ -141,6 +141,7 @@ function () { event.preventDefault(); newQuality = isHD ? 'large' : 'highres'; + this.trigger('videoPlayer.handlePlaybackQualityChange', newQuality); }