Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed course-run exam rule configuration

Browse Source
This commit is contained in:
Michael Roytman
2018-12-06 16:31:03 -05:00
committed by Dave St.Germain
parent 72a2e191fd
commit 23fcb7e7bb
20 changed files with 228 additions and 438 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cms/djangoapps/contentstore/proctoring.py
View File

@@ -79,7 +79,7 @@ def register_special_exams(course_key):
'is_practice_exam': timed_exam.is_practice_exam,
'is_active': True,
'hide_after_due': timed_exam.hide_after_due,
'backend': course.proctoring_configuration.get('backend', None),
'backend': course.proctoring_provider,
}
try:
@@ -103,7 +103,6 @@ def register_special_exams(course_key):
'exam_id': exam_id,
'set_by_user_id': timed_exam.edited_by,
'review_policy': timed_exam.exam_review_rules,
'rules': course.proctoring_configuration.get('rules', None)
}
# only create/update exam policy for the proctored exams
@@ -111,9 +110,7 @@ def register_special_exams(course_key):
try:
update_review_policy(**exam_review_policy_metadata)
except ProctoredExamReviewPolicyNotFoundException:
review_policy_has_rules = exam_review_policy_metadata.get('rules', None)
if timed_exam.exam_review_rules or review_policy_has_rules: # won't save an empty rule.
if timed_exam.exam_review_rules: # won't save an empty rule.
create_exam_review_policy(**exam_review_policy_metadata)
msg = 'Created new exam review policy with exam_id {exam_id}'.format(exam_id=exam_id)
log.info(msg)

10
cms/djangoapps/contentstore/tests/test_proctoring.py
View File

@@ -28,17 +28,12 @@ class TestProctoredExams(ModuleStoreTestCase):
"""
super(TestProctoredExams, self).setUp()
default_proctoring_provider = settings.PROCTORING_BACKENDS['DEFAULT']
self.course = CourseFactory.create(
org='edX',
course='900',
run='test_run',
enable_proctored_exams=True,
proctoring_configuration={
'backend': default_proctoring_provider,
'rules': settings.PROCTORING_BACKENDS[default_proctoring_provider]['default_rules'],
}
proctoring_provider=settings.PROCTORING_BACKENDS['DEFAULT'],
)
def _verify_exam_data(self, sequence, expected_active):
@@ -56,7 +51,6 @@ class TestProctoredExams(ModuleStoreTestCase):
# get the review policy object
exam_review_policy = get_review_policy_by_exam_id(exam['id'])
self.assertEqual(exam_review_policy['review_policy'], sequence.exam_review_rules)
self.assertEqual(exam_review_policy['rules'], self.course.proctoring_configuration['rules'])
if not exam['is_proctored'] and not exam['is_practice_exam']:
# the hide after due value only applies to timed exams
@@ -69,7 +63,7 @@ class TestProctoredExams(ModuleStoreTestCase):
self.assertEqual(exam['is_proctored'], sequence.is_proctored_exam)
self.assertEqual(exam['is_practice_exam'], sequence.is_practice_exam)
self.assertEqual(exam['is_active'], expected_active)
self.assertEqual(exam['backend'], self.course.proctoring_configuration['backend'])
self.assertEqual(exam['backend'], self.course.proctoring_provider)
@ddt.data(
(True, False, True, False, False),