From 2348ed3db14f143d781e2a7e46cf9928e4ee7ff7 Mon Sep 17 00:00:00 2001 From: Vasyl Nakvasiuk Date: Mon, 25 Feb 2013 18:38:47 +0200 Subject: [PATCH] fix empty display_name problem --- common/lib/xmodule/xmodule/seq_module.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/lib/xmodule/xmodule/seq_module.py b/common/lib/xmodule/xmodule/seq_module.py index 9da168255b..db8171e945 100644 --- a/common/lib/xmodule/xmodule/seq_module.py +++ b/common/lib/xmodule/xmodule/seq_module.py @@ -17,6 +17,7 @@ log = logging.getLogger(__name__) # OBSOLETE: This obsoletes 'type' class_priority = ['video', 'problem'] + def display_name(module): if hasattr(module, 'display_name'): return module.display_name @@ -24,6 +25,7 @@ def display_name(module): if hasattr(module, 'lms'): return module.lms.display_name + class SequenceModule(XModule): ''' Layout module which lays out content in a temporal sequence ''' @@ -84,14 +86,14 @@ class SequenceModule(XModule): 'title': "\n".join( display_name(grand_child) for grand_child in child.get_children() - if display_name(grand_child) is not None + if display_name(grand_child) ), 'progress_status': Progress.to_js_status_str(progress), 'progress_detail': Progress.to_js_detail_str(progress), 'type': child.get_icon_class(), 'id': child.id, } - if childinfo['title']=='': + if childinfo['title'] == '': childinfo['title'] = display_name(child) contents.append(childinfo)