From f2f44312d252da9d375044a0ae23c77e973fd3c2 Mon Sep 17 00:00:00 2001 From: Awais Date: Thu, 21 May 2015 15:42:54 +0500 Subject: [PATCH] ECOM-1600 fixing certs button issue. --- lms/djangoapps/courseware/tests/test_views.py | 11 ++++++++++- lms/djangoapps/courseware/views.py | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lms/djangoapps/courseware/tests/test_views.py b/lms/djangoapps/courseware/tests/test_views.py index ea7ad7517f..05e2634cfb 100644 --- a/lms/djangoapps/courseware/tests/test_views.py +++ b/lms/djangoapps/courseware/tests/test_views.py @@ -846,6 +846,8 @@ class IsCoursePassedTests(ModuleStoreTestCase): Tests for the is_course_passed helper function """ + SUCCESS_CUTOFF = 0.5 + def setUp(self): super(IsCoursePassedTests, self).setUp() @@ -854,7 +856,7 @@ class IsCoursePassedTests(ModuleStoreTestCase): org='edx', number='verified', display_name='Verified Course', - grade_cutoffs={'cutoff': 0.75, 'Pass': 0.5} + grade_cutoffs={'cutoff': 0.75, 'Pass': self.SUCCESS_CUTOFF} ) self.request = RequestFactory() @@ -874,6 +876,13 @@ class IsCoursePassedTests(ModuleStoreTestCase): # If user has below passing marks then False will return self.assertFalse(views.is_course_passed(self.course, None, self.student, self.request)) + @patch('courseware.grades.grade', Mock(return_value={'percent': SUCCESS_CUTOFF})) + def test_user_with_passing_marks_and_achieved_marks_equal(self): + # Mocking the grades.grade + # If user's achieved passing marks are equal to the required passing + # marks then it will return True + self.assertTrue(views.is_course_passed(self.course, None, self.student, self.request)) + @attr('shard_1') class GenerateUserCertTests(ModuleStoreTestCase): diff --git a/lms/djangoapps/courseware/views.py b/lms/djangoapps/courseware/views.py index c5910f78fe..3e0c31768a 100644 --- a/lms/djangoapps/courseware/views.py +++ b/lms/djangoapps/courseware/views.py @@ -1302,7 +1302,7 @@ def is_course_passed(course, grade_summary=None, student=None, request=None): if grade_summary is None: grade_summary = grades.grade(student, request, course) - return success_cutoff and grade_summary['percent'] > success_cutoff + return success_cutoff and grade_summary['percent'] >= success_cutoff @require_POST