From 1fa49ca1f863a9277a4ddaf40f7da90550bb43b1 Mon Sep 17 00:00:00 2001 From: David Baumgold Date: Wed, 18 Jun 2014 11:51:01 -0400 Subject: [PATCH] link to code ownership page from CONTRIBUTING.rst file --- CONTRIBUTING.rst | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index a92773515f..ffdf279253 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -101,7 +101,10 @@ If your pull request meets the requirements listed in the then it will be scheduled for code review by one or more core committers. This process sometimes takes awhile: currently, all core committers on the project are employees of edX, and they have to balance their time between code review -and new development. +and new development. Please also read our `code ownership page`_, which +lists areas and concepts in the codebase that are "owned" by certain developers. +If your change touches one of these areas or concepts, that developer should be +one of the reviewers. Once the code review process has started, please be responsive to comments on the pull request, so we can keep the review process moving forward. @@ -109,6 +112,8 @@ If you are unable to respond for a few days, that's fine, but please add a comment informing us of that -- otherwise, it looks like you're abandoning your work! +.. _code ownership page: https://github.com/edx/edx-platform/wiki/Code-Ownership + Step 6: Merge! ==============