From 10168b690881148e070d46e224e26f27c70bd931 Mon Sep 17 00:00:00 2001 From: Brian Talbot Date: Thu, 8 Jan 2015 21:28:33 -0500 Subject: [PATCH] ECOM-873 accessability updates for decoupled verification --- .../views/review_photos_step_view.js | 11 ++++++----- lms/static/sass/views/_login-register.scss | 2 +- lms/templates/verify_student/error.underscore | 7 +++++-- .../verify_student/face_photo_step.underscore | 2 +- .../verify_student/id_photo_step.underscore | 2 +- .../verify_student/intro_step.underscore | 8 ++++---- .../verify_student/make_payment_step.underscore | 8 ++++---- .../payment_confirmation_step.underscore | 17 +++++++++-------- .../review_photos_step.underscore | 12 +++++++----- .../verify_student/webcam_photo.underscore | 4 ++-- 10 files changed, 40 insertions(+), 33 deletions(-) diff --git a/lms/static/js/verify_student/views/review_photos_step_view.js b/lms/static/js/verify_student/views/review_photos_step_view.js index 2cbaba592b..b4a329abb7 100644 --- a/lms/static/js/verify_student/views/review_photos_step_view.js +++ b/lms/static/js/verify_student/views/review_photos_step_view.js @@ -83,14 +83,15 @@ var edx = edx || {}; }, expandCallback: function( event ) { - var title; + var $link = $(this), + $title = $link.closest('.help-tip'), + expanded = $title.hasClass('is-expanded'); event.preventDefault(); - $(this).next('.expandable-area' ).slideToggle(); - title = $( this ).parent(); - title.toggleClass( 'is-expanded' ); - title.attr( 'aria-expanded', !title.attr( 'aria-expanded' ) ); + $link.attr( 'aria-expanded', !expanded ); + $title.toggleClass('is-expanded') + .find('.expandable-area').slideToggle(); }, setSubmitButtonEnabled: function( isEnabled ) { diff --git a/lms/static/sass/views/_login-register.scss b/lms/static/sass/views/_login-register.scss index d1a824ae5e..c1cc521e3a 100644 --- a/lms/static/sass/views/_login-register.scss +++ b/lms/static/sass/views/_login-register.scss @@ -118,7 +118,7 @@ $sm-btn-linkedin: #0077b5; position: relative; background: white; padding: 0 10px; - z-index: 10; + z-index: 6; text-transform: none; font-size: 0.7em; font-weight: 600; diff --git a/lms/templates/verify_student/error.underscore b/lms/templates/verify_student/error.underscore index d1923dd911..4939e7add3 100644 --- a/lms/templates/verify_student/error.underscore +++ b/lms/templates/verify_student/error.underscore @@ -1,8 +1,11 @@
- +
-

<%- errorTitle %>

+

+ <%- gettext( "Error:" ) %> + <%- errorTitle %> +

<%= errorMsg %>

diff --git a/lms/templates/verify_student/face_photo_step.underscore b/lms/templates/verify_student/face_photo_step.underscore index ec31979f7e..e66870da45 100644 --- a/lms/templates/verify_student/face_photo_step.underscore +++ b/lms/templates/verify_student/face_photo_step.underscore @@ -17,7 +17,7 @@
  • <%- gettext( "Make sure your face is well-lit" ) %>
  • <%- gettext( "Be sure your entire face is inside the frame" ) %>
  • - <%= _.sprintf( gettext( "Once in position, use the camera button %(icon)s to capture your photo" ), { icon: '()' } ) %> + <%= _.sprintf( gettext( "Once in position, use the camera button %(icon)s to capture your photo" ), { icon: '()' } ) %>
  • <%- gettext( "Can we match the photo you took with the one on your ID?" ) %>
  • <%- gettext( "Use the retake photo button if you are not pleased with your photo" ) %>
    • diff --git a/lms/templates/verify_student/id_photo_step.underscore b/lms/templates/verify_student/id_photo_step.underscore index 24efa21a14..9e348c3b76 100644 --- a/lms/templates/verify_student/id_photo_step.underscore +++ b/lms/templates/verify_student/id_photo_step.underscore @@ -19,7 +19,7 @@
  • <%- gettext( "Ensure that you can see your photo and read your name" ) %>
  • <%- gettext( "Make sure your ID is well-lit" ) %>
  • - <%= _.sprintf( gettext( "Once in position, use the camera button %(icon)s to capture your ID" ), { icon: '()' } ) %> + <%= _.sprintf( gettext( "Once in position, use the camera button %(icon)s to capture your ID" ), { icon: '()' } ) %>
  • <%- gettext( "Use the retake photo button if you are not pleased with your photo" ) %>
    • diff --git a/lms/templates/verify_student/intro_step.underscore b/lms/templates/verify_student/intro_step.underscore index 3adda87712..6822162881 100644 --- a/lms/templates/verify_student/intro_step.underscore +++ b/lms/templates/verify_student/intro_step.underscore @@ -26,7 +26,7 @@

  • <%- gettext( "Activate Your Account" ) %>

    - +
    @@ -40,8 +40,8 @@

  • <%- gettext( "Photo ID" ) %>

    - - + +
    @@ -56,7 +56,7 @@

  • <%- gettext( "Webcam" ) %>

    - +
    diff --git a/lms/templates/verify_student/make_payment_step.underscore b/lms/templates/verify_student/make_payment_step.underscore index 9479f056c8..6ef7b798ee 100644 --- a/lms/templates/verify_student/make_payment_step.underscore +++ b/lms/templates/verify_student/make_payment_step.underscore @@ -121,7 +121,7 @@

  • <%- gettext( "Activate Your Account" ) %>

    - +
    @@ -135,8 +135,8 @@

  • <%- gettext( "Government-Issued Photo ID" ) %>

    - - + +
    @@ -147,7 +147,7 @@

  • <%- gettext( "Webcam" ) %>

    - +
    diff --git a/lms/templates/verify_student/payment_confirmation_step.underscore b/lms/templates/verify_student/payment_confirmation_step.underscore index c29a8b6642..e91761c4ed 100644 --- a/lms/templates/verify_student/payment_confirmation_step.underscore +++ b/lms/templates/verify_student/payment_confirmation_step.underscore @@ -86,7 +86,7 @@

  • <%- gettext( "Activate Your Account" ) %>

    - +
    @@ -104,8 +104,8 @@

  • <%- gettext( "Photo ID" ) %>

    - - + +
    @@ -120,7 +120,7 @@

  • <%- gettext( "Webcam" ) %>

    - +
    @@ -131,6 +131,11 @@
    • <% } %> diff --git a/lms/templates/verify_student/review_photos_step.underscore b/lms/templates/verify_student/review_photos_step.underscore index 73421fc980..727c56a461 100644 --- a/lms/templates/verify_student/review_photos_step.underscore +++ b/lms/templates/verify_student/review_photos_step.underscore @@ -10,12 +10,12 @@
    - + <%- _.sprintf( gettext( "/>
    - + <%- _.sprintf( gettext( "/>
    @@ -29,9 +29,11 @@
  • <%- gettext( "Is your name on your ID readable?" ) %>
  • <%- _.sprintf( gettext( "Does the name on your ID match your account name: %(fullName)s?" ), { fullName: fullName } ) %> @@ -13,7 +13,7 @@