From 1dcfaef70321c51a007df7862b435bbac1dc674f Mon Sep 17 00:00:00 2001 From: Awais Jibran Date: Mon, 22 Jul 2019 17:30:18 +0500 Subject: [PATCH] Fix Numeric input problems are backwards for right-to-left languages --- cms/static/sass/elements/_xblocks.scss | 5 +++++ cms/static/sass/vendor/bi-app/_mixins.scss | 6 ++++++ .../sass/course/courseware/_courseware.scss | 20 +++++++++++++------ lms/static/sass/vendor/bi-app/_mixins.scss | 6 ++++++ 4 files changed, 31 insertions(+), 6 deletions(-) diff --git a/cms/static/sass/elements/_xblocks.scss b/cms/static/sass/elements/_xblocks.scss index 832200618b..1f1ce3fc99 100644 --- a/cms/static/sass/elements/_xblocks.scss +++ b/cms/static/sass/elements/_xblocks.scss @@ -438,6 +438,11 @@ margin: ($baseline/2); padding: ($baseline/2); overflow: hidden; + + code::before, + code::after { + @include display-left-to-right(); + } } // STATE: container/component with children - abbreviated preview diff --git a/cms/static/sass/vendor/bi-app/_mixins.scss b/cms/static/sass/vendor/bi-app/_mixins.scss index e1adf07c89..ba610f962d 100755 --- a/cms/static/sass/vendor/bi-app/_mixins.scss +++ b/cms/static/sass/vendor/bi-app/_mixins.scss @@ -316,3 +316,9 @@ @content; } } + +@mixin display-left-to-right { + @if $bi-app-direction == rtl { + content: "\200E‎"; + } +} diff --git a/lms/static/sass/course/courseware/_courseware.scss b/lms/static/sass/course/courseware/_courseware.scss index c6553b4da0..f8aef34677 100644 --- a/lms/static/sass/course/courseware/_courseware.scss +++ b/lms/static/sass/course/courseware/_courseware.scss @@ -327,12 +327,15 @@ html.video-fullscreen { p { margin: 0; } + h4 { margin-top: ($baseline * 3/2); } + ul { margin: 0; } + .exam-action-button { margin-top: $baseline / 2; } @@ -348,7 +351,7 @@ html.video-fullscreen { position: relative; &.start-timed-exam { - margin-bottom:($baseline/2); + margin-bottom: ($baseline/2); display: block; &.action-primary { @@ -382,7 +385,7 @@ html.video-fullscreen { .proctored-exam-skip-confirm-wrapper { border-left: ($baseline/4) solid $red; - padding: $baseline ($baseline*1.5);; + padding: $baseline ($baseline*1.5); background-color: rgb(242, 244, 245); .msg-title { @@ -433,7 +436,6 @@ html.video-fullscreen { float: left; width: 80%; margin-bottom: 25px; - } a.contest-review { @@ -467,7 +469,7 @@ html.video-fullscreen { .faq-proctoring-exam { @extend .footer-sequence; - border-bottom : none; + border-bottom: none; a.footer-link { display: block; @@ -514,6 +516,11 @@ html.video-fullscreen { padding-bottom: 0; border-bottom: none; } + + code::before, + code::after { + @include display-left-to-right(); + } } .vert-mod { @@ -664,7 +671,9 @@ html.video-fullscreen { } } - .xqa-modal, .staff-modal, .history-modal { + .xqa-modal, + .staff-modal, + .history-modal { width: 80%; height: 80%; left: left(20%); @@ -749,7 +758,6 @@ html.video-fullscreen { .xmodule_VideoModule { margin-bottom: ($baseline*1.5); - } textarea.short-form-response { diff --git a/lms/static/sass/vendor/bi-app/_mixins.scss b/lms/static/sass/vendor/bi-app/_mixins.scss index e02d4d00ac..ec30498167 100755 --- a/lms/static/sass/vendor/bi-app/_mixins.scss +++ b/lms/static/sass/vendor/bi-app/_mixins.scss @@ -292,3 +292,9 @@ @content; } } + +@mixin display-left-to-right { + @if $bi-app-direction == rtl { + content: "\200E‎"; + } +}