From 1a28a2df3b3902caa8a3252b504e14ce963fb4a2 Mon Sep 17 00:00:00 2001 From: Hassan Raza Date: Mon, 28 Apr 2025 20:10:00 +0500 Subject: [PATCH] fix: Get latest existing notification for grouping (#36614) --- openedx/core/djangoapps/notifications/grouping_notifications.py | 2 +- .../notifications/tests/test_notification_grouping.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/openedx/core/djangoapps/notifications/grouping_notifications.py b/openedx/core/djangoapps/notifications/grouping_notifications.py index 5aa22d64ef..c855ca3d23 100644 --- a/openedx/core/djangoapps/notifications/grouping_notifications.py +++ b/openedx/core/djangoapps/notifications/grouping_notifications.py @@ -140,6 +140,6 @@ def get_user_existing_notifications(user_ids, notification_type, group_by_id, co notifications_mapping[notification.user_id].append(notification) for user_id, notifications in notifications_mapping.items(): - notifications.sort(key=lambda elem: elem.created) + notifications.sort(key=lambda elem: elem.created, reverse=True) notifications_mapping[user_id] = notifications[0] if notifications else None return notifications_mapping diff --git a/openedx/core/djangoapps/notifications/tests/test_notification_grouping.py b/openedx/core/djangoapps/notifications/tests/test_notification_grouping.py index dbb1afa0c4..debd72d901 100644 --- a/openedx/core/djangoapps/notifications/tests/test_notification_grouping.py +++ b/openedx/core/djangoapps/notifications/tests/test_notification_grouping.py @@ -188,5 +188,5 @@ class TestGetUserExistingNotifications(unittest.TestCase): result = get_user_existing_notifications(user_ids, notification_type, group_by_id, course_id) # Verify the results - self.assertEqual(result[1], mock_notification1) + self.assertEqual(result[1], mock_notification2) self.assertIsNone(result[2]) # user 2 has no notifications