From 1886e940ea3718ab26924c24fdc97263cc72cd4a Mon Sep 17 00:00:00 2001 From: Mubbshar Anwar <78487564+mubbsharanwar@users.noreply.github.com> Date: Thu, 2 Dec 2021 23:03:27 +0500 Subject: [PATCH] fix: event not firing (#29499) segment event was not working due to null user id for anonymous users VAN-741 --- lms/djangoapps/save_for_later/api/v1/views.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lms/djangoapps/save_for_later/api/v1/views.py b/lms/djangoapps/save_for_later/api/v1/views.py index 55655beb0b..129d07600f 100644 --- a/lms/djangoapps/save_for_later/api/v1/views.py +++ b/lms/djangoapps/save_for_later/api/v1/views.py @@ -15,8 +15,8 @@ from django.db import transaction from opaque_keys.edx.keys import CourseKey from edx_ace import ace from edx_ace.recipient import Recipient +from eventtracking import tracker -from common.djangoapps.track import segment from openedx.core.djangoapps.site_configuration import helpers as configuration_helpers from openedx.core.djangoapps.user_api.accounts.api import get_email_validation_error from openedx.core.djangoapps.content.course_overviews.models import CourseOverview @@ -29,6 +29,7 @@ log = logging.getLogger(__name__) POST_EMAIL_KEY = 'post:email' REAL_IP_KEY = 'openedx.core.djangoapps.util.ratelimit.real_ip' +USER_SENT_EMAIL_SAVE_FOR_LATER = 'edx.bi.user.save.for.later.email.sent' class SaveForLaterApiView(APIView): @@ -104,10 +105,10 @@ class SaveForLaterApiView(APIView): ) try: ace.send(msg) - segment.track( - user.id, - 'edx.bi.user.sent.email.save.for.later', + tracker.emit( + USER_SENT_EMAIL_SAVE_FOR_LATER, { + 'user_id': user.id, 'category': 'save-for-later', 'type': 'course' if course_id else 'program' }