From 213ade8cf7f8725777401f4b37c86db03c78210d Mon Sep 17 00:00:00 2001 From: Justin Hynes Date: Tue, 31 Jan 2023 08:51:53 -0500 Subject: [PATCH] fix: remove unused settings from edx-paltform related to learner record MFE [APER-2240] The monolith no longer needs to understand how to build URLs to the Learner Record MFE. The Credentials IDA has logic to determine if (and how) a request should be redirected to this MFE. This PR remove unused settings from edx-platform. We have already removed the use of these settings in #31672. --- lms/envs/common.py | 7 ------- lms/envs/devstack.py | 1 - openedx/core/djangoapps/credentials/config.py | 17 ----------------- 3 files changed, 25 deletions(-) delete mode 100644 openedx/core/djangoapps/credentials/config.py diff --git a/lms/envs/common.py b/lms/envs/common.py index dd17c36040..9704bc8193 100644 --- a/lms/envs/common.py +++ b/lms/envs/common.py @@ -4915,13 +4915,6 @@ DISCUSSIONS_MICROFRONTEND_URL = None # .. setting_default: None # .. setting_description: Base URL of the discussions micro-frontend google form based feedback. DISCUSSIONS_MFE_FEEDBACK_URL = None -# .. setting_name: LEARNER_RECORD_MFE_URL -# .. setting_default: None -# .. setting_description: Base URL of the micro-frontend responsible for displaying Learner Record and Program record -# pages. This MFE replaces the legacy frontend originally offered in the Credentials IDA. -# .. setting_warning: In order to route requests to the MFE correctly you must also create and enable the credentials -# app's `USE_LEARNER_RECORD_MFE` waffle flag. See openedx/core/djangoapps/credentials/config.py. -LEARNER_RECORD_MICROFRONTEND_URL = None # .. toggle_name: ENABLE_AUTHN_RESET_PASSWORD_HIBP_POLICY # .. toggle_implementation: DjangoSetting # .. toggle_default: False diff --git a/lms/envs/devstack.py b/lms/envs/devstack.py index bb7bb554b5..2ef060bb4b 100644 --- a/lms/envs/devstack.py +++ b/lms/envs/devstack.py @@ -369,7 +369,6 @@ ACCOUNT_MICROFRONTEND_URL = 'http://localhost:1997' COMMUNICATIONS_MICROFRONTEND_URL = 'http://localhost:1984' AUTHN_MICROFRONTEND_URL = 'http://localhost:1999' AUTHN_MICROFRONTEND_DOMAIN = 'localhost:1999' -LEARNER_RECORD_MICROFRONTEND_URL = 'http://localhost:1990' ################### FRONTEND APPLICATION DISCUSSIONS ################### DISCUSSIONS_MICROFRONTEND_URL = 'http://localhost:2002' diff --git a/openedx/core/djangoapps/credentials/config.py b/openedx/core/djangoapps/credentials/config.py deleted file mode 100644 index 159654be9f..0000000000 --- a/openedx/core/djangoapps/credentials/config.py +++ /dev/null @@ -1,17 +0,0 @@ -""" -This module contains various configuration settings via waffle switches for the Credentials app. -""" - -from edx_toggles.toggles import WaffleSwitch - -# Namespace -WAFFLE_NAMESPACE = 'credentials' - -# .. toggle_name: credentials.use_learner_record_mfe -# .. toggle_implementation: WaffleSwitch -# .. toggle_default: False -# .. toggle_description: This toggle will inform the Program Dashboard to route to the Learner Record MFE over the -# legacy frontend of the Credentials IDA. -# .. toggle_use_cases: open_edx -# .. toggle_creation_date: 2022-09-07 -USE_LEARNER_RECORD_MFE = WaffleSwitch(f"{WAFFLE_NAMESPACE}.use_learner_record_mfe", __name__)