Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't query for the user every time in FieldDataCache, just use the user_id instead

Browse Source
This commit is contained in:
Calen Pennington
2014-12-03 11:00:03 -05:00
parent f0e6cdd3d7
commit 14e6f3cc2b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lms/djangoapps/courseware/model_data.py
View File

@@ -244,7 +244,7 @@ class FieldDataCache(object):
assert(isinstance(key.block_scope_id, UsageKey)) assert(isinstance(key.block_scope_id, UsageKey))
field_object, _ = StudentModule.objects.get_or_create( field_object, _ = StudentModule.objects.get_or_create(
course_id=self.course_id, course_id=self.course_id,
student=User.objects.get(id=key.user_id), student_id=key.user_id,
module_state_key=key.block_scope_id, module_state_key=key.block_scope_id,
defaults={ defaults={
'state': json.dumps({}), 'state': json.dumps({}),
@@ -260,12 +260,12 @@ class FieldDataCache(object):
field_object, _ = XModuleStudentPrefsField.objects.get_or_create( field_object, _ = XModuleStudentPrefsField.objects.get_or_create(
field_name=key.field_name, field_name=key.field_name,
module_type=key.block_scope_id, module_type=key.block_scope_id,
student=User.objects.get(id=key.user_id), student_id=key.user_id,
) )
elif key.scope == Scope.user_info: elif key.scope == Scope.user_info:
field_object, _ = XModuleStudentInfoField.objects.get_or_create( field_object, _ = XModuleStudentInfoField.objects.get_or_create(
field_name=key.field_name, field_name=key.field_name,
student=User.objects.get(id=key.user_id), student_id=key.user_id,
) )
cache_key = self._cache_key_from_kvs_key(key) cache_key = self._cache_key_from_kvs_key(key)